Repository navigation
fix(openscd): close the modal menu before opening another modal - #174
Merged
clepski merged 1 commit intoOct 8, 2026
Merged
Conversation
Author
|
Basically only one line changed: |
Member
|
Sounds good to me to fix. |
Member
The modal mwc-drawer scrim stayed open and swallowed pointer events, so Settings and Plugins dialogs looked frozen (Escape still worked).
brabenetz
force-pushed
the
fix/dialog-clicks-behind-drawer-scrim
branch
from
September 24, 2026 08:37
42b1dc6 to
aa48454
Compare
brabenetz
marked this pull request as ready for review
September 29, 2026 10:38
brabenetz
requested review from
lorenzhoerburgerbearingpointcom and
philippilievskibearingpointcom
October 6, 2026 06:07
lorenzhoerburgerbearingpointcom
approved these changes
Oct 7, 2026
philippilievskibearingpointcom
approved these changes
Oct 7, 2026
clepski
requested changes
Oct 8, 2026
clepski
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The side menu is a modal
mwc-drawer. Choosing a menu item often opens a second modal (mwc-dialog: Settings, Plugins, Open, Save, …). Both overlays stay in the stack: In general this works, but under special circumstances — when a dialog opens on top while the drawer is still open — the drawer scrim can keep capturing clicks and the dialog can look frozen (only Escape still works).This applies to every menu item that opens a dialog. It showed up while consuming this package from CoMPAS (
com-pas/compas-open-scd) via a local link; two stacked modals are enough to trigger it.Changes
Layout.ts: close the drawer on every menu list action (menuUI.open = false) so only one modal is open. Ctrl+P goes through the Plugins menu item so it uses the same path.How to try
Open the menu and pick any item that shows a dialog (Settings, Plugins, Open, …). Dialog buttons and inputs should be clickable. Escape still dismisses the dialog.