Repository navigation
server: remove the unused joinWithInvite route - #3072
Merged
Merged
Conversation
POST /api/v3/joinWithInvite has no caller in any client, test or tool, and it admitted people past the conversation's gates: with no invite at all it created a participant row in an invite-only conversation, which the vote route then accepted as membership; it created rows before the external-id allowlist check; and it signed tokens with the internal numeric conversation id. The route, its handler and helpers are removed; the logout handler stays. Observable change: POST /api/v3/joinWithInvite now answers 404 and writes nothing. Votes, comments, nextComment, participationInit and participant resolution are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
Delphi Coverage Report
|
…module Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observable change:
POST /api/v3/joinWithInviteanswers 404 and writes nothing (previously 200/403/500). Nothing else changes; votes, comments, nextComment, participationInit and participant resolution are not in the diff. No schema change.Why. The route has no caller in any client (participation, alpha, admin, report), e2e test, CLI or doc. Integration tests against the current code showed:
Tests. New
server/__tests__/integration/join-with-invite.test.ts: 404 for anonymous and signed-in callers, no rows written in invite-only or allowlist conversations, and the invite-only check on votes still refuses (401).tsc --noEmit, eslint and prettier are clean. The route characterization inventory pins the registration count and needs the usual refresh with the next re-record.🤖 Generated with Claude Code