Repository navigation
characterization: the seed finds the vote-fixture helper before it is imported - #3146
Merged
Merged
Conversation
…importing the fixture vote helper The re-record job's math-seed service failed before writing anything: seed-pca2.py imports vote_fixtures at module level, on the assumption that pca2_votes had already put delphi/tests on sys.path. pca2_votes only adds it lazily, the first time semantic_votes() runs, so in the math-seed container the import raised ModuleNotFoundError: No module named 'vote_fixtures'. The seed now adds delphi/tests next to delphi itself, as the other callers of the helper do (ci/vote_convention/fixtures.py, ci/probe_box/local/pipeline_seed.py). The compose mount already provides the directory at /repo/delphi/tests. Votes are still drawn by meaning and stored through seed_vote/read_vote at the database's convention; no sign literal is added and nothing that is recorded changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test harness only; no product change.
The characterization re-record workflow (
characterization-rerecord.yml) has not completed since 2026-09-11. Its first break:server/characterization/seed-pca2.pyimports the vote-fixture helper (delphi/tests/vote_fixtures.py) at load time, but the path that provides it was only added oncesemantic_votes()ran, so themath-seedcontainer failed withModuleNotFoundError: No module named 'vote_fixtures'(run 39128089403, record stage). The seed now addsdelphi/teststo the path next todelphi, the way the other callers do. Votes still go throughseed_vote/read_vote; the sign lint is clean with no new allowlist entry.Verified on a work box: the seed stage completes. The record stage then stops on a second, separate break (the route inventory predates PR #3080, PR #3072 and the ops routes, and its ids are positional); that is its own change.
🤖 Generated with Claude Code
https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s