fix(tickets_v2): include superseded product versions in orders filter#995
Merged
Conversation
Editing a product creates a new revision and points old rows at it via superseded_by, but existing orders keep referencing the old product id in product_data. The Orders tab filtered strictly by the current product id, so orders placed before the most recent edit were silently excluded, while the Products tab's counts already rolled up the whole version chain. filter_orders now expands each requested product id to include its superseded versions before matching. fixes #994 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a product creates a new revision and points old rows at it via
superseded_by, but existing orders keep referencing the old product id
in product_data. The Orders tab filtered strictly by the current
product id, so orders placed before the most recent edit were silently
excluded, while the Products tab's counts already rolled up the whole
version chain. filter_orders now expands each requested product id to
include its superseded versions before matching.
fixes #994
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com