Repository navigation
Upgrade golang.org/x/text to clear HIGH CVEs - #127
Open
nthmost-orkes wants to merge 2 commits into
Open
nthmost-orkes wants to merge 2 commits into
nthmost-orkes wants to merge 2 commits into
Conversation
golang.org/x/text v0.14.0 -> v0.41.0 (go get + go mod tidy), clearing CVE-2026-56851 and CVE-2026-56852. x/text v0.41.0 requires go 1.25, so the go directive moves 1.23 -> 1.25.0 accordingly. go build ./... passes.
The go directive bump to 1.25 (required by golang.org/x/text 0.41.0) enables a
stricter 'go vet' that go test runs by default. It flagged a pre-existing
fmt.Errorf(message) in cmd/workflow.go. Use fmt.Errorf("%s", message).
c4lm
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the HIGH
golang.org/x/textCVEs from the Trivy scan.Fixes CVE-2026-56851 (needs v0.41.0) and CVE-2026-56852.
x/textis an indirect dependency, bumped viago get golang.org/x/text@v0.41.0 && go mod tidy.Heads up -- Go directive bump:
x/textv0.41.0 declaresgo 1.25.0in its own go.mod, so the module'sgodirective moves1.23 -> 1.25.0. This raises the minimum Go toolchain for conductor-cli. With the defaultGOTOOLCHAIN=auto, builds fetch 1.25 automatically; CI pinned below 1.25 would need bumping.Verification:
go build ./...passes locally (Go 1.27).User impact: the CLI pulled a
golang.org/x/textwith high-severity issues; this moves it to a patched release.Fixes #126