Repository navigation
Add NuGet lock file to close CVE-scan coverage gap - #180
Merged
Merged
Conversation
The Trivy scan reads resolved deps from a lock file; a bare .csproj isn't scannable, so csharp-sdk showed a false-clean 0. Enable RestorePackagesWithLockFile on the shipping Conductor project and commit packages.lock.json so transitive deps are visible to the scan. Current resolved tree scans clean (0 HIGH/CRITICAL).
c4lm
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the csharp-sdk CVE-scan blind spot.
The nightly Trivy scan reads resolved dependencies from a lock file. csharp-sdk committed none, so a bare
.csproj(version ranges, no pinned transitive graph) was unscannable and the SDK showed a false-clean0-- a blind spot, not a clean bill.This enables
RestorePackagesWithLockFileon the shippingConductorproject and commitspackages.lock.json, so the full resolved transitive tree is visible to the scan going forward.Current state: with the lock file in place, the resolved tree scans clean (0 HIGH/CRITICAL via Trivy) -- so this is purely a visibility fix, nothing to remediate today.
dotnet restore --locked-modepasses.User impact: none at runtime; this makes future dependency CVEs in the C# SDK actually detectable instead of silently missed.