Skip to content

ci(agent-e2e): track shared E2E_TEST_OSS_CONDUCTOR_VERSION org var #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nthmost-orkes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(agent-e2e): track shared E2E_TEST_OSS_CONDUCTOR_VERSION org var #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions .github/workflows/agent-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,18 @@ concurrency:
group: agent-e2e-${{ github.ref }}
cancel-in-progress: true

# Deliberately NOT the same knob as the integration-tests-oss job in
# pull_request.yml, despite the similar name. That job pins a *Docker image
# tag* (conductoross/conductor on Docker Hub), defaulted in
# scripts/docker-compose-oss.yaml and overridable via the
# E2E_TEST_OSS_CONDUCTOR_VERSION org variable. This is a *Maven Central
# artifact version* for the conductor-server boot JAR, which is a different
# registry with a different set of published versions -- notably it has no
# `latest`, which is what that org variable currently holds. It also carries a
# constraint that job does not: the /agent/* control plane and the
# TaskDef.runtimeMetadata persistence these suites exercise only exist from
# 3.32.0-rc.8 onward. So it is pinned independently and bumped deliberately.
# Shares the E2E_TEST_OSS_CONDUCTOR_VERSION org variable with the
# integration-tests-oss job in pull_request.yml, set by conductor's publish.yml
# on each release. That job consumes it as a *Docker image tag*
# (conductoross/conductor on Docker Hub); this job consumes it as a *Maven
# Central artifact version* for the conductor-server boot JAR. A concrete
# release (e.g. 3.33.0) is valid in both registries, so one variable serves
# both -- but it must never be set to `latest`, which Maven Central has no
# artifact for. One constraint to respect when bumping: the /agent/* control
# plane and TaskDef.runtimeMetadata persistence these suites exercise only
# exist from 3.32.0-rc.8 onward, so never pin below that.
env:
CONDUCTOR_OSS_VERSION: ${{ vars.CONDUCTOR_SERVER_VERSION || '3.32.1' }} # pinned conductor-oss release — see note above
CONDUCTOR_OSS_VERSION: ${{ vars.E2E_TEST_OSS_CONDUCTOR_VERSION || '3.33.0' }} # shared org var — see note above

jobs:
agent-e2e:
Expand Down
Loading