Repository navigation
ci(agent-e2e): track shared E2E_TEST_OSS_CONDUCTOR_VERSION org var - #533
Open
nthmost-orkes wants to merge 1 commit into
Open
nthmost-orkes wants to merge 1 commit into
nthmost-orkes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point
agent-e2e.ymlat the org-levelE2E_TEST_OSS_CONDUCTOR_VERSIONvariable instead of the never-createdCONDUCTOR_SERVER_VERSION, and bump the fork-PR fallback to3.33.0.Why
CONDUCTOR_SERVER_VERSIONwas never provisioned as an org variable, so this workflow has been running on its hardcoded fallback the entire time.E2E_TEST_OSS_CONDUCTOR_VERSIONis the variable that already drives the docker-compose e2e inpull_request.yml, and conductor'spublish.ymlnow bumps it on every release (conductor-oss/conductor#1764). Reading the same variable makes agent-e2e track the just-released server automatically.A concrete release is valid as both a Docker Hub tag and a Maven Central boot-JAR artifact, so one variable serves both e2e paths. It must stay a real version --
latesthas no Maven Central artifact, which is exactly what broke this path while the org var still heldlatest.Note
This replaces python-sdk's deliberate hardcoded pin (
3.32.0-rc18). It now auto-tracks the shared org variable like the java/javascript/csharp agent-e2e workflows, for a single source of truth across all four SDKs.