Repository navigation
Upgrade dependencies with known CVEs - #37
Merged
Merged
Conversation
Clears the ruby-sdk HIGH/CRITICAL findings from the Trivy scan: - concurrent-ruby 1.3.6 -> 1.3.8 (CVE-2026-54906 critical, CVE-2026-54904) - faraday 2.8.1 -> 2.15.0 (CVE-2026-54297) - addressable 2.8.8 -> 2.9.0 (CVE-2026-35611, transitive) Direct deps (concurrent-ruby, faraday) get raised floors in the gemspec so gem consumers resolve to patched versions, not just the dev lock; addressable is transitive and moves in Gemfile.lock only.
- rest_client_spec: faraday >= 2.9 stores keyword middleware options in @kwargs (not @Args); read that so the retry-config assertions work under faraday 2.15 - Gemfile: cap public_suffix < 7.0. The addressable 2.9.0 bump (dev-only, via webmock) pulled public_suffix 7, which needs Ruby >= 3.2 and broke the Ruby 3.0/3.1 CI jobs; 6.0.2 has no Ruby floor and still clears the CVEs.
c4lm
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the ruby-sdk HIGH/CRITICAL CVEs from the Trivy scan.
concurrent-rubyandfaradayare direct deps, so their gemspec floors are raised (>= 1.3.7and>= 2.14.3) -- this is what matters for gem consumers, since they resolve against the gemspec, not this repo's lock.addressableis transitive and moves inGemfile.lockonly. The lock also carries faraday 2.15's transitive changes (net-http, logger, json, public_suffix bump).Verification:
bundle lockresolves cleanly against the new constraints (concurrent-ruby 1.3.8, faraday 2.15.0, addressable 2.9.0). CI runs the test suite.User impact: anyone depending on the Ruby SDK pulled a concurrent-ruby with a critical issue plus high-severity faraday/addressable bugs; this raises the floors to patched releases.
Parent: #32
Fixes #34
Fixes #35
Fixes #36