Skip to content

feat(macos27): notice when expanding pushes icons into the overflow - #519

Merged
tieubao merged 1 commit into
developfrom
feat/overflow-notice-expand
Nov 16, 2026
Merged

tieubao merged 1 commit into
developfrom
feat/overflow-notice-expand

Conversation

@tieubao

@tieubao tieubao commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

What

Direct build on macOS 27. After you expand the bar by click or hotkey, if icons that were hidden now sit in macOS's own « button (they do not fit, for example right of the notch), Hidden Bar says so once. PR #488 only covered the collapse case (the arrow itself in «).

Notice: "Some icons are in the « button" / "Some icons do not fit in the menu bar, so macOS moved them into its own « button. Click « to see them. To make room, move icons you rarely use to the always-hidden section." One OK button.

  • Decision: SystemOverflowNoticePolicy.shouldShowAfterExpand(isExpanded:hiddenItemInOverflow:alreadyShown:). Shows only for expanded + item in « + not shown yet. Its own "shown" flag (systemOverflowExpandNoticeShown), separate from the collapse notice. Recorded before the alert opens, so it never repeats.
  • Detection (SystemOverflowExpandMatcher): of the bundles the last read put in the hidden section, a running third-party app is in « when a « exists and the app is missing from Accessibility (macOS lists only items that fit), or its item sits under a « or on no display. Apps that did not answer Accessibility are not judged. System extras are skipped.
  • Off the main thread as in feat(macos27): notice when the system overflow takes the arrow #488: the « read first (no « means no inventory walk), then one inventory snapshot, both off main; the alert runs outside any dispatch block. A collapse in between cancels it.
  • Only expandCollapseIfNeeded (click, hotkey, Shift-click) passes userInitiated. Hover, auto and reveal gestures do not.
  • App Store build compiles none of it (HIDDENBAR_NATIVE_VISIBILITY).
  • docs/MANUAL.md troubleshooting row, CHANGELOG Unreleased (Added).

Verification

  • scripts/test.sh in the mac-ui VM: Hidden Bar 664 passed, 0 failed; App Store 437 passed, 0 failed. New tests cover all 8 combinations of the decision, the separate flag, and the matcher (missing app, under «, on no display, unreadable, not running, system extras, no «).
  • The alert was rendered in the mac-ui VM from the app's own SystemOverflowNotice.makeExpandAlert(), light and dark.

Not verified

@tieubao
tieubao force-pushed the feat/overflow-notice-expand branch from 11b1a2c to a817ba8 Compare November 16, 2026 13:13
@tieubao
tieubao merged commit cad6afa into develop Nov 16, 2026
3 checks passed
@tieubao
tieubao deleted the feat/overflow-notice-expand branch November 16, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant