Repository navigation
Conversation
…facts One command for the GitHub (Sparkle) release: preflight, tests, archive and export, app checks, notarize and staple, zips, EdDSA sign, appcast, smoke test with host restore, and a checks.md with one row per check. It never tags, uploads or publishes; gh and git are wrapped to read verbs only. - release-helper.swift: Ed25519 verify (CryptoKit), the appcast item, and a merge that keeps every prior item byte-identical. - --check-app runs every app row; the sandbox row counts only after the Developer ID identity row passes, so an ad-hoc build cannot pass vacuously. - SUPublicEDKey, SUFeedURL and the Sparkle tarball digest are pinned. - test-release.sh: offline cases with fixtures and PATH stubs. - RUNBOOK: step 3 points at the script; the manual sandbox check now checks the Developer ID signature first, then the entitlement. - QUALITY.md: Q-REL-1 (no key material) and Q-REL-2 (prior items verbatim).
The smoke positive control ran a re-signed /bin/sleep copy inside a fake "Hidden Bar.app". macOS killed it with a launch constraint violation and showed a "Hidden Bar is damaged" dialog. The control now runs /bin/sleep in place; smoke_assert_process takes the expected executable as an optional fourth argument, so the check is the same without launching a bundle.
Info-Direct.plist on develop points SUFeedURL at consolelabs/hidden, so release.sh pinned the old org and would fail its own Feed URL row. Prior appcast items that still use dwarvesf URLs stay accepted.
The pinned feed URL and Sparkle key are asserted against the real plist, and the fixture bundles now carry the plist values instead of the pins, so a drifted pin can no longer hide itself.
main() runs with build, notarize, zip, sign, appcast and smoke stages stubbed: a failing check_app must exit 1 with a FAILED row and stop the later stages, and the same harness must exit 0 when it passes. The prior-app key check now runs inside stage_appcast with a stubbed curl serving a prior zip; the unit check on check_pubkey is renamed to what it tests.
An unreadable notarytool log now fails the row instead of reading as 'issues none'. appcast.xml is written as appcast.xml.unverified and renamed only after every appcast check passed. The branch lookup runs from the repo root (via cd, since the read-only git guard refuses -C). A prior item's shortVersionString must match [0-9A-Za-z._-]+ before it names a file. The unused sums local is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of done: scripts/release.sh
scripts/release.shturns the hand-run direct release (about 26 checks) into one command that builds and verifies the artifacts and writeschecks.md. It never tags, uploads or publishes. Head 5cbadef on origin/develop 05aecea.bash -n scripts/release.sh && bash scripts/test-release.shbash scripts/release.sh --guard-selftestbash scripts/release.sh --check-app "<scratch>/build-1.12.0/export/Hidden Bar.app"--check-app "<scratch>/build-1.12.0/unzip/Hidden Bar.app"--check-app "<scratch>/spec-ground/sbx/Hidden Bar.app"item-exact-output,appcast-prior-verbatimappcast.xmlbyte for bytepin-feed-url-matches-plist,pin-pubkey-matches-plistPINNED_FEED_URLandPINNED_PUBKEYequalSUFeedURLandSUPublicEDKeyinhidden/Info-Direct.plist(consolelabs/hidden)mainmain-check-app-failure-exits-1,main-all-stages-pass-exits-0pubkey-differs-from-prior-fails,pubkey-equals-prior-passesbash scripts/test.sh --dd <fresh dir>Green run
Negative control
Each block is
negctl.sh "$PWD" "bash scripts/test-release.sh" "<mutation>"at head 5cbadef. Every mutation was restored by negctl (git checkout HEAD -- <file>), exit 0 after restore, andgit status --porcelainshowed no tracked change after each run.release-helper.swiftmade to always say VALIDcheck_identityPINNED_FEED_URLreverted to dwarvesf/hidden (the pre-fix pin)check_app ... || finish 1inmainturned into|| trueappcast.xmlinstead ofappcast.xml.unverifiedcheck_pubkeycall replaced by a constantRows 1 and 2 are the two controls recorded before the review fixes (earlier counts 3 and 4 red; the new cases add one red each). Row 3 is the drift control for the feed pin.
Review fixes in this branch
hidden/Info-Direct.plist; the prior-item allowlist accepts both consolelabs and dwarvesf URLs because older published items still use dwarvesf.main, and the prior-zip branch of the appcast stage exercised with a stubbed curl.appcast.xml.unverifiedis renamed only after every check; the branch lookup runs from the repo root; a prior item's shortVersionString must match[0-9A-Za-z._-]+; the unusedsumslocal is gone.Deviation: the branch lookup uses
(cd "$ROOT" && git rev-parse ...), notgit -C "$ROOT", because the read-onlygitguard refuses-Con purpose (git -C . pushis one of its self-test refusals).Not proven
sign_update, the prior-zip downloads, and the smoke test with host restore. Those stages are covered offline by stubs (notarize-*,secrets-cleanup-on-failure,smoke-assert-*, the stubbedmainrun) and by reading the code against the 1.12.0 hand run, not by a run. Before the next release, runscripts/release.sh --notes <file>once on the Mini and compare itschecks.mdwith the 1.12.0 hand-run checks.appcast-named-only-after-checks) stubsrelease-helper verifyfor the prior enclosure, since the fixtures hold no private key to sign a prior zip; real signature checks are covered by the verify cases and by the live run.--check-appwas run against the notarized 1.12.0 export; no new archive was built here.open, or exec an app bundle; the smoke stage's launch path runs only in a live run.