Repository navigation
fix: take focus for the full menu bar option on macOS 14 and later - #532
Merged
Merged
Conversation
activate(ignoringOtherApps:) is ignored under cooperative activation, so the option switched to a regular app but never became the active one and the front app's menus kept the bar. Use activate() from macOS 14, keep the old call before it. The call sits behind a small seam so a unit test covers both paths.
A plain activate() is ignored too under cooperative activation: on macOS 27.0.1 the full menu bar option stayed inactive after the arrow click. The front app is now named as the one to take the active state from, with activate() as the fallback. Checked in a macOS 27.0.1 VM: the arrow click makes Hidden Bar the front app, in windowed and full screen Safari, and collapse hands focus back.
tieubao
force-pushed
the
fix/fullscreen-full-bar
branch
from
November 17, 2026 06:49
59b098a to
5eee1f8
Compare
tieubao
marked this pull request as ready for review
November 17, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
"Use the full menu bar on expanding" never took focus on macOS 14 and later. Hidden Bar switched to a regular app but stayed inactive, so the front app's menus kept the bar. Refs #142.
What
NSRunningApplication.activate(from:options:)), withactivate()as fallback. Older systems keepactivate(ignoringOtherApps:).FullBarActivating) so a unit test covers both paths.Checked
scripts/test.shfresh derived data: Hidden Bar 677 passed, App Store 443 passed, 0 failed.activate()ignored. After: Hidden Bar is the front app, in windowed and full screen Safari; collapse hands focus back to Safari and Safari stays in full screen.