Conversation
Keep dependency setup on the repository toolchain instead of updating stable and changing the user's global default. Include rust-analyzer in the pinned Rust 1.95.0 toolchain components. Signed-off-by: Tim Zhang <tim@hyper.sh>
Use edition 2024 and resolver 3 across the workspace and standalone prost crates. Set and inherit Rust 1.90 as the minimum supported version. Adapt reserved identifiers, macro fragments, unsafe calls, and temporary lifetimes. Address Clippy checks enabled by the new edition and minimum Rust version. Retain style edition 2021 until the formatting-only commit. Signed-off-by: Tim Zhang <tim@hyper.sh>
Remove the temporary style edition override and apply Rust 2024 formatting across the workspace and standalone prost crates. Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
changed the title
Tim-Zhang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All workspace members and both standalone Prost crates now use Rust 2024 and resolver 3, with Rust 1.90 as the minimum supported version (previously 1.70 for the runtime). The development toolchain stays pinned to Rust 1.95.0.
Adapt reserved identifiers, macro fragments, unsafe calls, and temporary lifetimes, and address Clippy checks enabled by the new edition and minimum Rust version. Dependency setup uses the repository toolchain without changing the global default, and the toolchain components include rust-analyzer.
The three commits separate toolchain setup, edition and MSRV compatibility, and formatting.
Validation: