compiler: stabilize generated module ordering - #326
Merged
Merged
Conversation
Preserve existing mod.rs lines in order and append sorted, unique module declarations. Do not reorder or deduplicate comments and attributes while merging generated modules. Regenerate the example module files and cover repeated generation, duplicate inputs, and preservation of existing lines. Signed-off-by: Tim Zhang <tim@hyper.sh>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Stabilizes generated mod.rs ordering while preserving existing content.
Changes:
- Preserve existing lines and append missing modules in sorted order.
- Add regression coverage for duplicates, comments, and attributes.
- Refresh example module files.
File summaries
| File | Description |
|---|---|
example/protocols/sync/mod.rs |
Updates synchronous module ordering. |
example/protocols/asynchronous/mod.rs |
Updates asynchronous module ordering. |
compiler/src/codegen.rs |
Implements stable module generation and tests it. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wllenyj
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Customize.gen_modis enabled, the compiler writesmod.rsby iterating aHashSet. Rebuilding the workspace can therefore reorder tracked example module files and leave a diff after every generation. The same implementation can also reorder comments and attributes or remove repeated attribute lines.Preserve existing lines in their original order and append only missing module declarations, sorted by name. Refresh the two example
mod.rsfiles to match the stable output. The regression test covers a missing file, existing comments and repeated attributes, duplicate inputs, and regeneration with reordered inputs.Follow-up to #232.