Skip to content

Remove broken has_downloads check #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobsjo wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −14
Open

Remove broken has_downloads check #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/main/js/bundles/mapapps-github-manager/BundleDetailsController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,18 +103,7 @@ export default class BundleDetailsController {
return;
}
const item = await this.store.get(id);
if (item?.has_downloads) {
this._createWindow(item, i18n);
} else {
const w = (this.detailWindow = this.windowManager.createModalWindow({
title: i18n.noReleasesTitle,
draggable: true,
dndDraggable: false,
content: i18n.noReleasesYet,
closable: true
}));
w.show();
}
this._createWindow(item, i18n);
}

async _lookupAvailableTags(repositoryName) {
Expand Down
1 change: 0 additions & 1 deletion src/main/js/bundles/mapapps-github-manager/nls/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ module.exports = {
windowTitle: "Bundle '${name}'",
createWindowTitle: "Bundle Upload",
noReleasesYet: "Sorry, this bundle doesn't have any releases yet.",
noReleasesTitle: "No releases found",
notFound: "Sorry, we could not locate this bundle on GitHub.",
integrationFailed: "Sorry, the bundle could not be integrated into map.apps.",
downloading: "Fetching bundle",
Expand Down
1 change: 0 additions & 1 deletion src/main/js/bundles/mapapps-github-manager/nls/de/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ module.exports = {
windowTitle: "Bundle '${name}'",
createWindowTitle: "Bundle hochladen",
noReleasesYet: "Dieses Bundle hat leider noch keine Releases.",
noReleasesTitle: "Kein Release gefunden",
notFound: "Das Bundle konnte leider nicht von GitHub heruntergeladen werden.",
integrationFailed: "Ein Fehler trat auf, das Bundle konnte leider nicht in map.apps integriert werden.",
integrationSuccess: "Bundle installiert.",
Expand Down
Loading