Refactoring of mapping between the upstream tool/resource/prompt name - #124
Open
cafalchio wants to merge 20 commits into
Open
Refactoring of mapping between the upstream tool/resource/prompt name#124cafalchio wants to merge 20 commits into
cafalchio wants to merge 20 commits into
Conversation
cafalchio
force-pushed
the
mapping_upstream
branch
from
September 1, 2026 09:19
a93714e to
adbbfa8
Compare
lucarlig
requested changes
Sep 1, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes until the tuple order is confirmed and resource-template routing is accounted for.
lucarlig
previously approved these changes
Sep 1, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
- Field name is wrong.
resources_templatesshould beresource_templates, matching MCP terminology and the linked issue’s wire contract. - This changes the hot path and removes prefix/alias routing, but _context/wiki/routing.md was not updated, ask bob please.
- Cleanup gap: NameAlias and the three backend alias sets now have no production consumer, leaving a redundant second routing model. They should be removed
lucarlig
self-requested a review
September 1, 2026 15:08
dawid-nowak
reviewed
Sep 2, 2026
| pub struct VirtualHost { | ||
| pub backends: HashMap<String, BackendMCPGateway>, | ||
| #[serde(default)] | ||
| pub tools: HashMap<String, ServiceRoute>, |
Contributor
There was a problem hiding this comment.
What the key here? Make it more descriptive in code so it is obvious without additional comments.
For example, instead of:
pub tools: HashMap<String, ServiceRoute>,
use
pub type DownstreamToolName= String;
pub tools: HashMap<DownstreamToolName, ServiceRoute>,```
Contributor
Author
There was a problem hiding this comment.
I learned about type alias Yesterday. Let me fix it.
dawid-nowak
reviewed
Sep 2, 2026
|
|
||
| #[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)] | ||
| pub struct VirtualHost { | ||
| pub backends: HashMap<String, BackendMCPGateway>, |
Contributor
There was a problem hiding this comment.
Same thing, as below. It is not clear what the key is here.
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
force-pushed
the
mapping_upstream
branch
from
September 2, 2026 10:24
1630015 to
2ea8795
Compare
dawid-nowak
reviewed
Sep 2, 2026
|
|
||
| #[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)] | ||
| pub struct VirtualHost { | ||
| pub backends: HashMap<String, BackendMCPGateway>, |
Contributor
Author
There was a problem hiding this comment.
Added DownstreamBackendName
dawid-nowak
requested changes
Sep 2, 2026
dawid-nowak
left a comment
dawid-nowak
left a comment
Contributor
There was a problem hiding this comment.
More changes around improving clarity of user_store
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
dawid-nowak
reviewed
Sep 2, 2026
| pub backends: HashMap<String, BackendMCPGateway>, | ||
| pub backends: HashMap<DownstreamBackendName, BackendMCPGateway>, | ||
| #[serde(default)] | ||
| pub tools: HashMap<DownstreamToolName, ServiceRoute>, |
Contributor
There was a problem hiding this comment.
ServiceName.backend_name is still a string, it should mach DownstreamBackendName
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
force-pushed
the
mapping_upstream
branch
from
September 2, 2026 15:39
150f15d to
484e5fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated VirtualHost in user_store.rs to receive tools, prompts and resources.
closes IBM/mcp-context-forge#6450