Skip to content

Security Hardening and Find Ring Improvements for com.moyoung.ring - #1

Open
cookiebaits wants to merge 1 commit into
mainfrom
harden-and-improve-ring-app-11999238470078141397
Open

Security Hardening and Find Ring Improvements for com.moyoung.ring#1
cookiebaits wants to merge 1 commit into
mainfrom
harden-and-improve-ring-app-11999238470078141397

Conversation

@cookiebaits

Copy link
Copy Markdown
Owner

I have implemented several security hardening measures and robustness improvements to the "Da Rings" application.

Key changes include:

  1. Security Hardening:
    • Disabled ADB backups (android:allowBackup="false") to protect user data.
    • Enforced HTTPS-only traffic (android:usesCleartextTraffic="false").
    • Restricted over 60 activities by setting android:exported="false", significantly reducing the application's attack surface.
  2. Robustness Enhancement:
    • Modified FindRingViewModel (via Smali) to perform a real-time connection check before initiating the "Find Ring" command, preventing errors and improving UX.
  3. Android 15 Compatibility:
    • Verified that all foreground services and PendingIntent flags comply with the latest Android requirements (SDK 35).
  4. Repackaging Documentation:
    • Created a detailed README.md containing step-by-step instructions on how to rebuild, align, and sign the application as an .apk or .xapk.

The project remains fully rebuildable, which I verified using apktool.


PR created automatically by Jules for task 11999238470078141397 started by @cookiebaits

- Disabled allowBackup and CleartextTraffic in Manifest.
- Restricted exported activities to reduce attack surface.
- Added connection check in FindRingViewModel.smali.
- Verified Android 15 compatibility and rebuildability.
- Added comprehensive README.md with repackaging instructions.

Co-authored-by: cookiebaits <186959723+cookiebaits@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant