Skip to content

feat: Allow configuring ipFamilies for the service - #286

Open
wiiaam wants to merge 2 commits into
coredns:masterfrom
wiiaam:ipfamilies
Open

wiiaam wants to merge 2 commits into
coredns:masterfrom
wiiaam:ipfamilies

Conversation

@wiiaam

@wiiaam wiiaam commented Oct 31, 2026

Copy link
Copy Markdown

Why is this pull request needed and what does it do?

Exposes the ipFamilies option for the service, so that the IP family can be configured, for example a v6 only deployment

Which issues (if any) are related?

n/a

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Signed-off-by: William Howell <wiiam24@gmail.com>
Signed-off-by: William Howell <wiiam24@gmail.com>

@hagaibarel hagaibarel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

Comment thread charts/coredns/Chart.yaml
apiVersion: v2
name: coredns
version: 1.49.0
version: 1.49.1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 1.49.1
version: 1.50.0

I think bumping a minor is more fitting here (we're adding something not fixing)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants