Repository navigation
refactor(engine): decompose God Classes (Eval, Exp, Mappings, QueryPlan) and eliminate historical LDScript/KGRAM relics - #651
Merged
remiceres merged 7 commits intoOct 27, 2026
Conversation
…arLint alerts in core.next - Extract 7 SRP pattern evaluators from Eval.java into dedicated components: EvalMinus, EvalUnion, EvalService, EvalValues, EvalFilter, EvalBind, EvalSubQuery - Extract variable scoping and pattern traversal from Exp.java into ExpPatternScope.java - Add unit test suites for all extracted evaluators and scope analyzer - Fix 172 SonarLint issues across 32 test files in core.next (naming S100/S101, text blocks S6203, constants S1170, scope S1450/S3398, escapes S5665, whitespace S2479) - Zero SonarLint warnings across all 974 files (main + test) in core.next - Fixes #650
…ter, distinct filter, aggregator, and relational operations
…d QueryExpIndexer
…d indexing branches
… prune dead hooks
|
Test Results 436 files 436 suites 29s ⏱️ Results for commit 11dcb8f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #650
Summary of Changes
God Class Decompositions:
Eval.java(-628 lines): Extracted 7 SRP evaluators (EvalMinus,EvalUnion,EvalService,EvalValues,EvalFilter,EvalBind,EvalSubQuery).Exp.java(-379 lines): ExtractedExpPatternScope.java.Mappings.java(-1,005 lines): ExtractedMappingsSorter,MappingsDistinctFilter,MappingsRelationalOperations,MappingsAggregator.QueryPlan.java(-543 lines): ExtractedQueryClauses.javaandQueryExpIndexer.java.Scaffolding & Dead Code Elimination:
Pointerable,PointerObject,Loopable,IterableEntity,PointerType, andExtension.getValue(String, int),getBinding(int),getList()) fromMappingandMemory.ExprType, unused URIs inExpType, and unused prefixes inMessage.Mapping.project()where unprojected variables were retained in internal maps.Architecture & Event Streamlining:
Group.javafrompatterntosolutionpackage.ProcessVisitorandProcessVisitorDefaultnotification contracts (removed uncalled dead hooks:path,step,slice,produce).Quality & Validation:
corese-core(4,880+ tests in 27s).