Repository navigation
Hold imports to BEA's summary groups in the balance, and condition service exports on the summary rows (#1288, #1250) - #1303
Conversation
…vice exports on summary F040 (#1288, #1250) Two flags, both off: - hold_imports_on_summary_groups: the Step 5 balance holds MCIF by summary group (import_group_holds, the same GroupHold as TOP/SUB) instead of one soft column total. In 2017 service imports enter at the published $267.2bn and leave at $247.0bn. - condition_service_exports_on_summary: each service summary group of F04000 is scaled to BEA's summary Use F040; the ITA growth blends keep only the detail split. Goods exports stay on Census trade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…itioned (#1250) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test rebuild: both fixes work, and the tables still balanceRun 43442148416, build Service exports (#1250). Every service row equals BEA's summary Service imports (#1288). Within 0.1% of BEA every year:
The largest remaining row miss is other professional services ( Where the restored imports went. Service rows,
Domestic production moves the same amount onto goods commodities, so industry output is unchanged. The largest moves are inside the professional services block: scientific R&D ( Balance. Next. Turning the flags on means a re-pin to a build of this code, as in #1302. 🤖 Generated with Claude Code |
Impact on N: small, with one outlierTotal emission factors (N) on the test build
The largest movers other than the outlier are under 3.2% in every year: computers ( The outlier is 🤖 Generated with Claude Code |
bl-young
left a comment
There was a problem hiding this comment.
Looks good. Real problems on both sides: the balance was walking service imports off the groups #785 already put them on (~$20bn/yr), and service export growth blends drift ~40% on rows like 514 / 561 / 55 while the balance barely corrects them. Holding MCIF by summary group and conditioning + Tier-1 fixing service F04000 is the right shape.
Mechanics reuse the existing pieces rather than inventing parallel ones: import holds are the tax GroupHold path for MCIF (seed already conditioned, so no tax-style pre-hold needed), and service export conditioning shares _group_factors with the NIPA FD conditioner instead of stuffing F04000 into CONDITIONED_COLUMNS (goods must stay on Census; the Tier-1 lock is export-specific). Fine to turn both on in the re-pin, same pattern as #1302; 826ea66 grades clean and N is mostly quiet (S00102 is the product-mix outlier worth naming in the pin PR).
One Q: is_service_group / GOODS_SUMMARY_PREFIXES looks like the same goods-vs-service cut as service_trade_vs_published.service_rows() -- intentional to keep them separate for now, or worth one shared helper later so they cannot drift?
…1303 review) service_rows() now calls nowcast_fd_conditioning.is_service_group, so the grader and the export conditioning can't disagree on what a service is. Same 40 summary rows as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@bl-young Thanks. Not intentional, and worth fixing now while it's small: Noted on 🤖 Generated with Claude Code |
…1164f (#1314) * feat(config): turn on v1.0 holds for services seed, summary trade, commercial kWh Enable hold_services_seed_at_last_sas_year, hold_imports_on_summary_groups, condition_service_exports_on_summary, and commercial_kwh_follow_intermediate_inputs on the nine v1.0 configs, and require the three Step 5-7 holds in the rebuild flag check. * feat(config): pin v1.0 to CI rebuild v1.0.0_2b1164f Retarget the nine v1.0 configs, 2024 balanced SUT and Cornerstone GHG pins, and upstream FBS inputs to the rebuild from Actions run 43526965633. * docs(analysis): move IV and B tracker currents to v1.0.0_2b1164f Equal- and spend-weight IV on the flags-on pin rebuild; landfill drops below 0.2 after calendar-2017 waste weights.
Closes #1288 and #1250 once the rebuild grades clean. Both flags are off in this PR. They get turned on with the re-pin after the test rebuild, as #1260 and #1302 did.
What this does
1.
hold_imports_on_summary_groups(#1288). #785 scales each summary group of the seed's imports (MCIF) to BEA's summary Supply table. The Step 5 balance, though, holds imports only as one soft column total (T7), and the service import cells are free, so the commodity identities move imports between groups. In 2017, service imports enter the balance at the published $267.2bn and leave at $247.0bn (v1.0.0_fd271dc).With the flag, the balance holds
MCIFby summary group, the same way it already holdsTOP/SUB(GroupHold). The newimport_group_holdstargets BEA's summaryMCIFfor each group, less the frozen cells. The detail cells inside a group stay free, and the held groups replace the T7 column total. Restored service imports then raise those rows' supply, so the balance has to raise their use too, mostly business services bought by industries.2.
condition_service_exports_on_summary(#1250). Service exports (F04000) are each row's published 2017 value moved by a blend of ITA categories. By 2024 the blends are off by about 40% on data processing (514, +42.7%), administrative and support (561, -37.6%) and management of companies (55, +42.1%), 2018-2024 means onfd271dc. The balance barely moves exports, so the error is in the blends.With the flag,
condition_service_exports_on_summaryscales each service summary group ofF04000to BEA's summary UseF040for that year, with the guardsnowcast_fd_conditioningalready uses for the NIPA columns: an empty group or a sign disagreement keeps a factor of 1. The blends keep only the detail split inside each group. Goods exports stay on Census trade, andOtherandUsedare left alone. It runs inderive_initial_Y_purafter #1295's anchoring.The balance then keeps those cells where conditioning put them:
fix_service_exportsmakes the serviceF04000cells Tier 1 fixed in the Use mask, so each row closes on its other cells. Without it the balance would move them again. Onfd271dcit took pipelines' (486) export error from $47M to $527M a year, and banking's (521CI) from $51M to $673M.Tests
import_group_holdstargets the published groups less frozen cells. On a small Supply block where the rows would move imports between groups, the held block keeps each group and the industry column absorbs the move instead.fix_service_exportsfixes service export cells and leaves goods free.F040(2023 workbook), goods rows don't move, and the split inside a group is unchanged.is_service_groupexcludes goods, government,OtherandUsed.Test rebuild
Run 43442148416 on the throwaway branch
service_trade_rebuild_check: this branch with both flags on in the nine v1.0 configs. Nothing is uploaded. It is graded withservice_trade_vs_publishedagainstv1.0.0_fd271dc; results go here when it finishes.🤖 Generated with Claude Code