Repository navigation
fix(ui): the confirmation-depth field sets the depth only inside a room - #337
Merged
Merged
Conversation
…de a room The 0.3.2 AppImage's log had a QML TypeError at RoomComposer.qml:838 on Start something. The composer exists there before any room does, and the depth field's initial text fired onTextChanged, which set room.splitXmrDepth on an undefined room. It now sets it only when there is a room (#333 added the field). Tested-Behavior: checked on the rebuilt 0.3.2 AppImage under Xvfb — its log had the TypeError at Start something before this change, and the release gate re-runs that check on this commit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Session-Id: 836705fe-fda9-501b-8ac2-1ce50b5af64a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.3.2 release check found a QML TypeError at RoomComposer.qml:838 on Start something, from #333's depth field: the field's initial text set
room.splitXmrDepthbefore a room existed. The field now sets it only when there is a room. The fix is re-checked on the rebuilt AppImage before the release goes out.🤖 Generated with Claude Code