Repository navigation
Switch Sign on in production, sealed by SSL.com eSealing - #341
Merged
Merged
Conversation
The worker seals completed documents with Cal.com, Inc.'s OV document signing certificate in SSL.com eSigner, converted to eSealing, through the CSC API (SIGN_SEALER=csc). The client secret and password are in the stage secret, so they leave unset_secrets. SIGN_DOCUMENTS_BUCKET is set for web, api, worker and sign, which turns Sign on. A test PDF sealed with these values validates in pyHanko (trusted to SSL.com's root, DigiCert timestamp, OCSP in the DSS). Legal has reviewed the consent disclosure and the certificate wording; the price of sign.completed_requests is still to come. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
co-5b1lenc0l11, valid until 2027-11-06) in eSigner, converted to eSealing (authMode: implicit), through the CSC API:SIGN_SEALER=cscand theSIGN_CSC_*settings.coss/production(set withput-secret.sh), so they leaveunset_secrets.SIGN_CSC_TOTP_SECRETstays unset, because the eSealing credential needs no one-time password.SIGN_DOCUMENTS_BUCKETis set for web, api, worker and sign.packages/sign/AGENTS.mdis updated, and the root AGENTS.md no longer lists Sign in production as not built. Legal has reviewed the consent disclosure and the certificate wording;sign.completed_requestsstill has no price.Testing
credentials/listandcredentials/infofind the credential (CN=Cal.com, Inc., key enabled, certificate valid, implicit auth).seal:testwith these exact values produced a PDF that pyHanko judges VALID:terraform applyhas already run from this branch, before merging, because services pick up new task definitions on deploy. It added the new task definitions. It also applied two changes from main that had been merged but not applied: the SES monthly budget, and the access-log masking Lambda's code.bun run verifypasses.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.