Repository navigation
Conversation
…you between computers (BRA-3274) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ent, and simplify the store Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, and never lose items on a failed read or write Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GET /phone/v1/attention and berthd mcp's berth_attention tool list the box's open attention items as briefs: kind, title, options, status, session and snooze, never an item's details or answer. Read only; the phone's info lists attention in its capabilities on a box that keeps items. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Stener1 is attempting to deploy a commit to the seanbrydonio's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #219 (the box's attention items), rebased onto
mainwith #207 (phone API v2). Only the last commit is new here; review it once #219 has settled.Summary
A phone and an agent read what needs a person through the surfaces they already have, instead of a new API. Both are read only.
Both go through one shape,
AttentionItem.Brief()(internal/box/attention.go):It has no
details,answer,closed_reasonorby. Those stay on the box's own API, the same way theattention.*events leave an item's words out. Settled items aren't listed. If the store can't read its file, the phone gets a 500, not an empty list.Evidence
Live, on a real box (
.claude/skills/verify-berthd/scripts/attention-reads-live.sh, new): it builds berthd and runs a box in a network namespace of its own, with a dummy100.64.7.9, so its phone listener gets a 1379 of its own. Then it posts an ask about a session (with details), puts a snooze mark on a signal key, and posts and answers a third item. It reads them back through the phone listener and throughberthd mcp, and checks both againstGET /v1/attention?open=1with the words taken out.[{"key":"signal:acme-shop-sh-1igb:waiting","revision":1,"kind":"mark","status":"open","snoozed_until":"2030-01-01T09:00:00Z", …}, {"key":"session:acme-shop-sh-1igb","revision":1,"kind":"decision","title":"Ship the acme checkout on Friday?", "options":[{"label":"Ship"},{"label":"Wait","description":"after the sale"}],"recommended":"Ship","status":"open","session":"acme-shop-sh-1igb", …}]infoanswers"capabilities":["transcript","events","push","interrupt","attention"].Unit:
TestThePhoneListsTheBoxsOpenAttentionItemsWithoutTheirWords: the route equals the store's open list, is filtered by session, answers[]for none, gets 401 without the token or with a wrong one, refuses POST/PATCH/DELETE and leaves the item as it was, andinfolistsattention.TestThePhoneSaysWhenTheBoxCantReadItsAttentionItems: an unreadable store answers 500, a box with no store answers 501 and itsinfodoesn't listattention.TestTheAttentionToolReadsTheBoxsOpenItemsWithoutTheirWords: the tool callsGET /v1/attention?open=1[&session=]and returns the briefs, with no details.Checks:
go vet ./...,go test -race ./...(see below) anddocs-sitebuild pass. This PR has no app changes. Fork PR CI needs a maintainer's approval and therun-cilabel.The verify skill gets
features/phone-and-mcp-reads.mdand a row in its map. Docs:reference/phone-api.mdx(the route and the capability), the MCP tool table inguides/runs.mdx, and the changelog.Merge Danger
Door: two-way
Additive read routes: one phone route, one MCP tool, one capability string. Reverting removes them; nothing is stored.
Blast Radius: small
A phone or an agent can now read an open item's title and option labels and descriptions. Anything with the phone token already reads agents' conversations, which carry the same questions, so this exposes nothing new. Clients that compare
info.capabilitiesexactly will see one more entry.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.