Skip to content

fix(tests): update compiler output to the latest nightly - #635

Open
m4tx wants to merge 2 commits into
masterfrom
fix-snapshots
Open

fix(tests): update compiler output to the latest nightly#635
m4tx wants to merge 2 commits into
masterfrom
fix-snapshots

Conversation

@m4tx

@m4tx m4tx commented Aug 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@m4tx
m4tx requested review from a team and a lite review from Copilot August 7, 2026 18:14
@github-actions github-actions Bot added C-lib Crate: cot (main library crate) C-macros Crate: cot-macros labels Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Rust UI test expectation files to match the latest nightly compiler diagnostics output format, keeping the test suite in sync with upstream rustc changes.

Changes:

  • Refreshed expected stderr for an invalid request handler UI test to reflect updated type formatting and trait-impl help text.
  • Refreshed expected stderr for a derive-macro UI test to reflect rustc’s newer “implementors” listing format (including workspace-qualified paths).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cot/tests/ui/unimplemented_request_handler.stderr Updates expected diagnostic output for invalid request handler errors to match nightly rustc formatting.
cot-macros/tests/ui/derive_api_operation_response_missing_trait_impl.stderr Updates expected diagnostic output for missing ApiOperationResponse impl to match nightly rustc’s newer help/impl listing format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Projectcot
Branchfix-snapshots
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
13,786.00 µs
(+73.45%)Baseline: 7,948.08 µs
14,750.67 µs
(93.46%)
json_api/json_api📈 view plot
🚷 view threshold
997.21 µs
(-6.53%)Baseline: 1,066.89 µs
1,384.95 µs
(72.00%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
971.99 µs
(-2.40%)Baseline: 995.88 µs
1,263.08 µs
(76.95%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
935.13 µs
(-2.49%)Baseline: 959.04 µs
1,226.81 µs
(76.22%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
16,573.00 µs
(-3.59%)Baseline: 17,189.72 µs
21,743.12 µs
(76.22%)
🐰 View full continuous benchmarking report in Bencher

@github-actions github-actions Bot added the A-ci Area: CI (Continuous Integration) label Aug 7, 2026
@m4tx

m4tx commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

To be fair, I'm not entirely sure how come we were missing some snapshot test outputs, and how come they only cause problems in coverage tests. But I guess it's good it works now?

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 90.35% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ElijahAhianyo

Copy link
Copy Markdown
Contributor

To be fair, I'm not entirely sure how come we were missing some snapshot test outputs, and how come they only cause problems in coverage tests. But I guess it's good it works now?

Yeah, on second look, the newly generated snapshots seem to have existing counterparts that are exactly the same. I'm wondering how we were able to generate them when there's been no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI (Continuous Integration) C-lib Crate: cot (main library crate) C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants