fix(tests): update compiler output to the latest nightly - #635
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Rust UI test expectation files to match the latest nightly compiler diagnostics output format, keeping the test suite in sync with upstream rustc changes.
Changes:
- Refreshed expected stderr for an invalid request handler UI test to reflect updated type formatting and trait-impl help text.
- Refreshed expected stderr for a derive-macro UI test to reflect rustc’s newer “implementors” listing format (including workspace-qualified paths).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cot/tests/ui/unimplemented_request_handler.stderr | Updates expected diagnostic output for invalid request handler errors to match nightly rustc formatting. |
| cot-macros/tests/ui/derive_api_operation_response_missing_trait_impl.stderr | Updates expected diagnostic output for missing ApiOperationResponse impl to match nightly rustc’s newer help/impl listing format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Project | cot |
| Branch | fix-snapshots |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 13,786.00 µs(+73.45%)Baseline: 7,948.08 µs | 14,750.67 µs (93.46%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 997.21 µs(-6.53%)Baseline: 1,066.89 µs | 1,384.95 µs (72.00%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 971.99 µs(-2.40%)Baseline: 995.88 µs | 1,263.08 µs (76.95%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 935.13 µs(-2.49%)Baseline: 959.04 µs | 1,226.81 µs (76.22%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 16,573.00 µs(-3.59%)Baseline: 17,189.72 µs | 21,743.12 µs (76.22%) |
|
To be fair, I'm not entirely sure how come we were missing some snapshot test outputs, and how come they only cause problems in coverage tests. But I guess it's good it works now? |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Also adds some missing snapshots.
Yeah, on second look, the newly generated snapshots seem to have existing counterparts that are exactly the same. I'm wondering how we were able to generate them when there's been no change. |
No description provided.