CBD-6817, docker script and template for rosetta-mdb. - #250
mhocouchbase wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new Dockerfile template does not currently handle multi-arch @@ARCH@@ substitution and the release URL handling needs to be parameterized to preserve staging/URL behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds support in the Dockerfile generator for a new product image, couchbase-mongodb-compatibility (rosetta-mdb / cbmcd), including a new Dockerfile template and README resources so the image can be generated like the other Couchbase products.
Changes:
- Introduces
ProductMongoDBCompatibilityto the generator and enables arm64 generation for it. - Adds a Dockerfile template to download/install the
cbmcdbinary and run it as thecouchbaseuser. - Adds a minimal README resource for the generated image directory.
File summaries
| File | Description |
|---|---|
| generate/templates/couchbase-mongodb-compatibility/Dockerfile.template | New Dockerfile template for installing/running cbmcd (rosetta-mdb). |
| generate/resources/couchbase-mongodb-compatibility/README.md | New README resource for the generated image output. |
| generate/generator/generate.go | Registers the new product and wires generator params/arches/base image for it. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3599d5c to
e6b6325
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The base-image registry reference is incorrect, and product generation is incomplete without a version directory or generated artifacts.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
generate/generator/generate.go:105
- Adding this product to
default_productsdoes not actually create an image:generateAllDockerfilesonly processes version directories already present undercommunity/<product>orenterprise/<product>, and this PR adds none. As a result, the documentedgo generateflow never emits a cbmcd Dockerfile or README; add the version directory/generated artifacts, or defer registering the product until one exists.
ProductMongoDBCompatibility,
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
docker script and template for rosetta-mdb.
-Ming