Updates to Dependencies, Build Chain, and Examples - #374
Conversation
- replace eslint with oxlint - add vscode suggested extensions and settings - replace npm test:plus w/ npm check
Node 18 was end-of-lifed in March 2025. Production cql-execution still works with it, but some of our dev/test libraries don't.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
- Coverage 89.57% 88.70% -0.87%
==========================================
Files 55 59 +4
Lines 4855 4933 +78
Branches 1391 1429 +38
==========================================
+ Hits 4349 4376 +27
Misses 322 322
- Partials 184 235 +51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dehall
left a comment
There was a problem hiding this comment.
This looks good to me and I'd be ok with merging as-is. But since it has been a couple weeks since this was submitted you may want to bump dependencies one more time just to get the latest.
My only concern is that this is the kind of PR where the things that go wrong are things I wasn't aware of, like how others interact with the library. But to your point, I think if we bump the major version number then anyone who is using this should be able to figure out any breaking changes.
| "private": true, | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "esbuild exec-age.js --bundle --platform=browser --format=iife --target=es2020 --outfile=dist/cql4browsers.js", |
There was a problem hiding this comment.
This is very minor but I would propose naming this output file something else. We're getting rid of the included cql4browsers so having anything refer to that name could potentially cause confusion.
This PR makes non-trivial updates to some of our dependencies, our build chain, and our examples. These changes include:
Some of these changes might be considered breaking (particularly dropping Node 18 and dropping cql4browsers), so we should consider if this warrants a major version change. In practice, I doubt this will break any existing implementations, but if we follow semver strictly, we probably should bump it.
Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: