Skip to content

fix(desktop): correct unsigned and Windows builds - #649

Merged
forhappy merged 1 commit into
crab-v2from
codex/fix-alpha-platform-packaging
Nov 5, 2026
Merged

forhappy merged 1 commit into
crab-v2from
codex/fix-alpha-platform-packaging

Conversation

@forhappy

@forhappy forhappy commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Unsigned macOS packaging imported the working directory as a certificate because CI supplied CSC_LINK as an empty string. Remove signing inputs entirely for unsigned builds; preserve the signed-build branch and its credential checks. This also prevents the same certificate-path problem on Windows.

Worktree metadata now uses the existing filesystem-identity normalizer for persistence and reconciliation. Windows verbatim paths and filesystem aliases resolve to the same worktree, while UI/command paths retain Git's spelling. Resolve metadata before move/remove deletes the old directory; apply the same identity rule to prune. Add a real alias regression test that failed before the fix.

The cherry-pick fixture now declares LF text files with .gitattributes, keeping its exact-byte assertion deterministic under core.autocrlf=true. Product Git behavior and assertions are unchanged. Ubuntu's npm failure was ECONNRESET; restart it with the corrected release source. No dependency or lockfile changes.

Validation:

  • Reproduced empty-certificate import, CRLF mismatch, and lost alias metadata before fixing them.
  • 64 native worktree tests and 13 operation tests with forced CRLF configuration passed.
  • Fresh production sidecar RPC create/save/restart/list/move/remove lifecycle passed, including pre-existing alias metadata and returned display paths.
  • Built a macOS arm64 ZIP using the actual CI packaging script with empty signing variables; both packaged-app smoke tests passed.
  • All 15 packaging tests, production sidecar build, rustfmt, actionlint, and diff checks passed. Cross-platform CI remains the Windows/native installer proof.

Prepare alpha.1 release notes for the already merged core schema changes and remove the retired migration claim. The alpha tag remains unpublished and will move only within the user's existing authorization.

@forhappy
forhappy merged commit 77ff871 into crab-v2 Nov 5, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant