Repository navigation
fix(desktop): correct unsigned and Windows builds - #649
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsigned macOS packaging imported the working directory as a certificate because CI supplied CSC_LINK as an empty string. Remove signing inputs entirely for unsigned builds; preserve the signed-build branch and its credential checks. This also prevents the same certificate-path problem on Windows.
Worktree metadata now uses the existing filesystem-identity normalizer for persistence and reconciliation. Windows verbatim paths and filesystem aliases resolve to the same worktree, while UI/command paths retain Git's spelling. Resolve metadata before move/remove deletes the old directory; apply the same identity rule to prune. Add a real alias regression test that failed before the fix.
The cherry-pick fixture now declares LF text files with .gitattributes, keeping its exact-byte assertion deterministic under core.autocrlf=true. Product Git behavior and assertions are unchanged. Ubuntu's npm failure was ECONNRESET; restart it with the corrected release source. No dependency or lockfile changes.
Validation:
Prepare alpha.1 release notes for the already merged core schema changes and remove the retired migration claim. The alpha tag remains unpublished and will move only within the user's existing authorization.