Repository navigation
fix(desktop): unblock packaged release smoke - #650
Merged
Merged
Conversation
Close inherited Chromium descriptors before starting the Linux PTY daemon. Bind native qualification tests to the CLI in the selected packaged app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux packaged smoke hangs after Electron quits because the persistent PTY daemon inherits Chromium descriptors, retaining DevTools sockets and browser files. Close those descriptors at the Linux daemon exec boundary while preserving its Node IPC channel. macOS/Windows retain their existing fork path; daemon upgrades originate inside the already isolated Node daemon and deliberately transfer PTY descriptors.
The storage qualifier also reruns native tests without selecting their bundled CLI. Bind both native consumers to the CLI inside the selected package, and honor the existing CRAB_PACKAGED_APP path for qualification outside release/.
Validation:
Cross-platform publication remains gated on the fresh tagged workflow. Linux VFS coordinator descriptor auditing remains follow-up work within the documented desktop NFS qualification gate.