Repository navigation
Fix desktop runtime for the v2 alpha - #651
Merged
Merged
Conversation
Keep token and PID files on disk while all daemon peers resolve the same profile-bound IPC address. Protect live tokens during duplicate startup.
Poll inherited nonblocking descriptors for readiness. Finish borrowed writes before the terminal reader closes the descriptor.
Use the native command processor for default Windows sessions. Exercise concurrent requests through the client that correlates their replies.
Keep POSIX descriptor and mode assertions on Unix. Verify the actual packaged daemon and use native paths in shell working-directory fixtures.
forhappy
marked this pull request as ready for review
November 5, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, use named pipes for the PTY daemon and start the Windows command processor when no shell is selected. Launch the durable daemon through the system shell so it cannot retain Electron's handles after the app quits. Keep Git subprocesses off the agent's RPC stdin; Git for Windows otherwise stalls before
remote get-urlruns. Commands that supply Git input keep their own pipes.Linux now polls inherited PTY descriptors for readiness and releases them after pending writes finish. Windows repository, worktree, and workspace labels show the folder name. Use native path and Git fixtures; limit only live descriptor transfer and POSIX permission assertions to Unix.
Validation: