Skip to content

Update docker-compose.yml - #1529

Open
KambleSahil3 wants to merge 1 commit into
credebl:mainfrom
KambleSahil3:main
Open

Update docker-compose.yml#1529
KambleSahil3 wants to merge 1 commit into
credebl:mainfrom
KambleSahil3:main

Conversation

@KambleSahil3

@KambleSahil3 KambleSahil3 commented Nov 28, 2025

Copy link
Copy Markdown
Contributor
  • update master-table.json path
  • add volume to store bulk issuance files

Summary by CodeRabbit

  • Chores
    • Updated service data storage paths for improved file organization.
    • Added dedicated export file storage configuration to support export functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

- update master-table.json path
- add volume to store bulk issuance files

Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
@coderabbitai

coderabbitai Bot commented Nov 28, 2025

Copy link
Copy Markdown

Walkthrough

Updated docker-compose.yml to restructure the prisma seed data file path into a nested directory and added volume mounts for uploaded file exports in the issuance service and top-level service configuration.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yml
Updated prisma seed data volume path from credebl-master-table.json to credebl-master-table/credebl-master-table.json (nested directory); added volume mounts for uploadedFiles/exports in issuance service and top-level services to mount $PWD/apps/uploadedFiles/exports to /app/uploadedFiles/exports

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify that the nested directory structure for credebl-master-table/credebl-master-table.json exists on the host and is correctly positioned in the codebase
  • Confirm that the new uploadedFiles/exports mount paths are intended and align with application expectations

Possibly related PRs

Suggested reviewers

  • GHkrishna

Poem

🐰 A nested path, a cleaner way,
Files tucked in folders—hip hooray!
Exports mount where they belong,
Docker dances to a better song! 📦✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and overly broad, lacking specific detail about what aspect of docker-compose.yml is being updated. Consider a more specific title like 'Update docker-compose.yml paths and add volume mounts for bulk issuance' that conveys the primary changes being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab4ac6 and 4c033c0.

📒 Files selected for processing (1)
  • docker-compose.yml (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-17T08:03:16.180Z
Learnt from: KambleSahil3
Repo: credebl/platform PR: 1518
File: libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json:11-20
Timestamp: 2025-11-17T08:03:16.180Z
Learning: In the credebl/platform repository, seed data files like libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json intentionally contain empty strings for sensitive fields (email, username, passwords, API keys, etc.) because these values are populated from .env file at runtime, not hardcoded in the JSON.

Applied to files:

  • docker-compose.yml
🔇 Additional comments (1)
docker-compose.yml (1)

28-28: The docker-compose volume mount is misconfigured and will cause the seed service to fail at runtime.

The seed service code (libs/prisma-service/prisma/seed.ts) expects to read from prisma/data/credebl-master-table/credebl-master-table.json (nested directory structure), but the volume mount in docker-compose only mounts the flat file itself, not the directory containing it.

Current mount (broken):

- $PWD/libs/prisma-service/prisma/data/credebl-master-table.json:/app/libs/prisma-service/prisma/data/credebl-master-table.json

Required mount (to match seed.ts expectation):

- $PWD/libs/prisma-service/prisma/data/credebl-master-table:/app/libs/prisma-service/prisma/data/credebl-master-table

The mount must include the parent directory (credebl-master-table/) rather than just the JSON file, so the nested structure credebl-master-table/credebl-master-table.json is accessible to the seed service inside the container.

⛔ Skipped due to learnings
Learnt from: KambleSahil3
Repo: credebl/platform PR: 1518
File: libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json:11-20
Timestamp: 2025-11-17T08:03:16.180Z
Learning: In the credebl/platform repository, seed data files like libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json intentionally contain empty strings for sensitive fields (email, username, passwords, API keys, etc.) because these values are populated from .env file at runtime, not hardcoded in the JSON.

Comment thread docker-compose.yml
@ajile-in
ajile-in requested review from ajile-in and ankita-p17 and removed request for GHkrishna and pranalidhanavade August 29, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants