Update docker-compose.yml - #1529
Conversation
- update master-table.json path - add volume to store bulk issuance files Signed-off-by: Sahil Kamble <sahil.kamble@ayanworks.com>
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docker-compose.yml(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-17T08:03:16.180Z
Learnt from: KambleSahil3
Repo: credebl/platform PR: 1518
File: libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json:11-20
Timestamp: 2025-11-17T08:03:16.180Z
Learning: In the credebl/platform repository, seed data files like libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json intentionally contain empty strings for sensitive fields (email, username, passwords, API keys, etc.) because these values are populated from .env file at runtime, not hardcoded in the JSON.
Applied to files:
docker-compose.yml
🔇 Additional comments (1)
docker-compose.yml (1)
28-28: The docker-compose volume mount is misconfigured and will cause the seed service to fail at runtime.The seed service code (
libs/prisma-service/prisma/seed.ts) expects to read fromprisma/data/credebl-master-table/credebl-master-table.json(nested directory structure), but the volume mount in docker-compose only mounts the flat file itself, not the directory containing it.Current mount (broken):
- $PWD/libs/prisma-service/prisma/data/credebl-master-table.json:/app/libs/prisma-service/prisma/data/credebl-master-table.jsonRequired mount (to match seed.ts expectation):
- $PWD/libs/prisma-service/prisma/data/credebl-master-table:/app/libs/prisma-service/prisma/data/credebl-master-tableThe mount must include the parent directory (
credebl-master-table/) rather than just the JSON file, so the nested structurecredebl-master-table/credebl-master-table.jsonis accessible to the seed service inside the container.⛔ Skipped due to learnings
Learnt from: KambleSahil3 Repo: credebl/platform PR: 1518 File: libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json:11-20 Timestamp: 2025-11-17T08:03:16.180Z Learning: In the credebl/platform repository, seed data files like libs/prisma-service/prisma/data/credebl-master-table/credebl-master-table.json intentionally contain empty strings for sensitive fields (email, username, passwords, API keys, etc.) because these values are populated from .env file at runtime, not hardcoded in the JSON.



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.