Skip to content

test(plugins): fix interactive terminal test on GitHub Actions - #855

Merged
joaoopereira merged 1 commit into
developmentfrom
codex/fix-plugin-terminal-github-actions
Oct 19, 2026
Merged

joaoopereira merged 1 commit into
developmentfrom
codex/fix-plugin-terminal-github-actions

Conversation

@joaoopereira

Copy link
Copy Markdown
Member

What was done

Execute_InTerminal_PluginCanUseSpectreMultiSelectionPrompt fails on GitHub Actions because Spectre.Console detects GITHUB_ACTIONS=true and disables interaction even inside the test's pseudo-terminal.

Remove GITHUB_ACTIONS only from the terminal test helper's child process environment so Spectre detects the actual terminal. The redirected-output test continues to verify non-interactive behavior.

Validation checklist

  • Code validation: two-line test-only change; no CLI behavior changes.
  • All 26 plugin tests passed with GITHUB_ACTIONS=true CI=true, including the interactive prompt and redirected-output integration tests. The reported failure was reproduced before the fix.
  • Release non-integration suite: 778 passed, 2 skipped, with GitHub Actions variables enabled.
  • NuGet minimum package-age check and commitlint passed.
  • Target branch is development.
  • Main WorkItem is linked: none supplied.

The broader local pre-commit test run encountered unrelated integration failures (Invalid repository type "Portal", expected one of: CIFS, NPM.) and was stopped. The test hook was bypassed for this commit; commitlint was run separately.

@joaoopereira
joaoopereira enabled auto-merge (rebase) October 19, 2026 09:14
@github-actions

Copy link
Copy Markdown
Contributor

.NET Test Results

View full test report

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
cmf 48% 48% ➖
core 76% 59% ✔
Summary 59% (6418 / 10809) 54% (3346 / 6248) ➖

@joaoopereira
joaoopereira merged commit d027e42 into development Oct 19, 2026
2 checks passed
@joaoopereira
joaoopereira deleted the codex/fix-plugin-terminal-github-actions branch October 19, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants