Skip to content

Add draft entry so solvers can mark tentative letters - #588

Merged
mdirolf merged 4 commits into
crosshare-org:masterfrom
ianfhunter:draft_pencil
Sep 17, 2026
Merged

mdirolf merged 4 commits into
crosshare-org:masterfrom
ianfhunter:draft_pencil

Conversation

@ianfhunter

Copy link
Copy Markdown
Contributor

In the solving mode of Crosshare, add a "Draft" mode, enabled with "." to give a visually different entry so that one can track answers that are "locked in" or ones that are unconfident.

As described in #414 , the behaviour is the same if all cells are filled out, versus non-draft cells - it will bring up the end screen/incomplete screen.

image

Basic appearance:
image
image

Interaction with hilights:
image
image

Also works fine with rebuses.

Closes #414

@ianfhunter
ianfhunter marked this pull request as ready for review September 14, 2026 19:34
@mdirolf

mdirolf commented Sep 14, 2026

Copy link
Copy Markdown
Member

Screenshots look great, as does the code from the quick glace I gave it. Will try to give a thorough review or merge tomorrow. Thank you!

@mdirolf

mdirolf commented Sep 17, 2026

Copy link
Copy Markdown
Member

I'm not sure this is worth any time to fix but one minor issue I noticed is that the color of the rebus text while it's being edited is based on the current draft status of that particular cell, not the current draft setting. Once the rebus is saved it seems to behave as expected.

I.e. go into draft mode and put a single letter in a cell. Exit draft mode and go back to that cell and start to enter a rebus - the color of the text as you're editing it will be the draft color.

@mdirolf mdirolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I made a note about the color of rebus entries but that's the only thing I saw that could use improvement. LMK if you feel like taking a look at that - otherwise I think I'm OK with merging this as-is.

@ianfhunter

Copy link
Copy Markdown
Contributor Author

Looks good - I made a note about the color of rebus entries but that's the only thing I saw that could use improvement. LMK if you feel like taking a look at that - otherwise I think I'm OK with merging this as-is.

I think I fixed the rebus now. Subtle one - thanks for catching

@mdirolf

mdirolf commented Sep 17, 2026

Copy link
Copy Markdown
Member

Looks good - going to merge. Thanks again!

@mdirolf
mdirolf merged commit 6fef637 into crosshare-org:master Sep 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pencil-in feature

2 participants