Repository navigation
Conversation
Android appends ".json" to files served as application/json, so downloading an .ipuz produced "puzzle.ipuz.json". Send the file as application/octet-stream so the .ipuz extension is preserved. Adds a regression test for the response headers of /api/ipuz/[puzzleId]. Fixes crosshare-org#603 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Author
|
Note on alternatives: I also tried switching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603
Problem
Downloading a puzzle as
.ipuzon Android producespuzzle.ipuz.json./api/ipuz/[puzzleId]responds withContent-Type: application/json, and Android appends.jsonto the filename for that type.Change
Send the response as
application/octet-streamso the.ipuzextension is preserved.Content-Dispositionand the other headers are unchanged.Testing
.ipuz.json), and verified the fix on the same device (now.ipuz).app/__tests__/ipuzApi.test.ts, which calls the route handler withgetPuzzle/exportIpuzmocked and asserts theContent-TypeandContent-Dispositionheaders. It fails without the fix.tsc --noEmitand prettier are clean on the changed files.This adds the first API route test, using
jest.unstable_mockModule. Happy to add similar header tests for thepuzandpdfroutes in a follow-up if that's useful.🤖 Generated with Claude Code