Repository navigation
fix: narrow copy_paste_detection exception for enqueue._build_parser (a271) - #73
Merged
Merged
Conversation
…hide (a271) Gourmand is about to honour `pattern` on exceptions (crunchtools/gourmand#43). Until now the existing entry on this file suppressed every finding of its check; this adds an item-scoped entry for the one finding it was hiding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jgC5WYMYiuEavEkLHa
Member
Author
|
Second-seat review (a295), head 0cbb120: approve.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crunchtools/gourmand#43 makes Gourmand honour
patternon exceptions. A pattern now matches the finding's item, or its message when the finding has no item. Thecopy_paste_detectionentry onsrc/deployer/enqueue.py(pattern = "parse_status") has been suppressing the whole file. That included a second finding,_build_parsermatchingfollow._build_parser, which would fire once #43 ships.I chose an exception over a code change. The two functions build the parsers of two different programs (cve-enqueue and release-follow) with different flags. What matches is argparse's construct, add_argument, return shape, and a shared builder would couple two CLIs that change independently. The new entry is
item = "_build_parser", which today's Gourmand already honours.Checked locally: 0 findings with stock v0.16.5 (
:latest), 0 with the #43 patched binary, andsdlc pushis green.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jgC5WYMYiuEavEkLHa