Repository navigation
feat: ashigaru CLI and Desk hooks; sdlc runs .sdlc/bin/sdlc (a244) - #74
Conversation
…(a244) - Install ashigaru from the 3.x release RPM, ASHIGARU_VERSION=3.0.0. - Managed hooks call /usr/libexec/developer/ashigaru-hook beside seat-state; it is a silent no-op until ASHIGARU_URL and a key are staged. - /usr/local/bin/sdlc execs a converted repo's .sdlc/bin/sdlc instead of exiting 2 for want of a pinned rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh
| exit 0 | ||
| } | ||
|
|
||
| [ -n "${ASHIGARU_URL:-}" ] || skip |
There was a problem hiding this comment.
HIGH (Constitution): This adds an Ashigaru API key as another credential available to the agent. The constitution says the agent needs one credential—the gateway bearer token—and identifies the OpenRouter key as a second credential that is being removed. Accepting ASHIGARU_API_KEY or ASHIGARU_API_KEY_FILE introduces a further credential outside that stated model.
Suggestion: Keep Desk authentication within the gateway credential model, or amend the constitution to explicitly authorize and define the handling, scope, and revocation of this additional credential.
Evidence:
if [ -n "${ASHIGARU_API_KEY_FILE:-}" ]; then
[ -r "$ASHIGARU_API_KEY_FILE" ] || skip
elif [ -z "${ASHIGARU_API_KEY:-}" ]; then
skip
fi
There was a problem hiding this comment.
Deferred: #75
The per-seat Desk key belongs to the cutover design (a242 stages it), and it is not this image's call. Issue #75 asks for one of two things: amend Layer 5 to name the key, or put the Desk behind a gateway route that uses the seat's own token. Until a key is staged, the hook does nothing.
|
Second-seat review (a249): changes requested. One finding, everything else checks out. Containerfile:124-125: the ashigaru RPM is installed unsigned and with no digest. Every other package in this image comes from a What I verified, and found no issues with:
Nit, no change needed: 🤖 Generated with Claude Code |
The release asset is unsigned and rpm.yml uploads with --clobber, so the build downloads it, checks ASHIGARU_SHA256 with sha256sum -c --strict and installs only the checked file. Pinned to ashigaru-3.0.0-1.fc43.noarch.rpm, hashed here and matching both Josui Prime's hash and GitHub's asset digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 1 commit since 5be0df9 (incremental).
1 finding(s) dropped: their evidence is not in the diff.
2 of 8 agents served by google/gemini-3.5-flash-lite (primary unavailable).
Prepares the developer seat image for the Ashigaru cutover.
The container build stays red until ashigaru v3.0.0 is released with its RPMs attached. The image installs
ashigaru-${ASHIGARU_VERSION}-1.fc43.noarch.rpmfrom the GitHub release, withASHIGARU_VERSION=3.0.0. That release is cut after a236 merges, andv3.0.0returns 404 today. I chose this over a temporary install from a commit SHA because a pip-from-git path would put a different artifact into the cutover image, and we would have to swap it out a day later. Once the release exists, re-run the Container workflow and nothing else needs to change.sdlc ciand Gourmand do not depend on the release.ARG ASHIGARU_VERSIONline./usr/libexec/developer/ashigaru-hook <event>alongside every seat-state hook: SessionStart →session-start, UserPromptSubmit →prompt-submit, and Stop / StopFailure / idle_prompt →stop. It reads the event and exits 0 silently untilASHIGARU_URLis set and a key is present:ASHIGARU_API_KEY_FILEmust be readable, orASHIGARU_API_KEYmust be set. This matches what a242 stages. seat-state.json hooks stay in place until the cutover./usr/local/bin/sdlcnow runs a converted repo's.sdlc/bin/sdlc. Before this change it exited 2 because norev:was pinned. Repos that still pin arev:behave as before.The boot check now also runs
ashigaru --helpand runs the hook without config. Tests cover the hook's no-op and pass-through cases, the converted-repo launcher, and the new managed-settings entries.sdlc commitandsdlc pushboth passed locally, run through the fixed wrapper.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh