Skip to content

chore: float the sdlc gates on quay.io/crunchtools/sdlc - #101

Merged
fatherlinux merged 2 commits into
mainfrom
chore/sdlc-floating
Nov 17, 2026
Merged

fatherlinux merged 2 commits into
mainfrom
chore/sdlc-floating

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

The last fleet-wide PR wave: this repo's gates move to the floating sdlc, so what they run changes when the image does and no pull request has to bump a pin.

What changed

  • .sdlc/bin/sdlc (new, executable): python-sdlc's bin/sdlc-bootstrap. It asks quay.io/crunchtools/sdlc for its launcher and runs it. It names no release, so nothing ever bumps it.
  • .pre-commit-config.yaml: the rev-pinned python-sdlc hooks (or the standalone Gourmand and Gatehouse hooks) become two local hooks running .sdlc/bin/sdlc commit and .sdlc/bin/sdlc push. Other hooks are kept.
  • .github/workflows/: the sdlc ci job runs .sdlc/bin/sdlc ci with SDLC_IMAGE: ${{ vars.SDLC_IMAGE }}. Its name, and so the required check, is unchanged. Workflows the stub does not cover are kept; quay.io/crunchtools/python-sdlc becomes quay.io/crunchtools/sdlc.
  • .specify/ is not touched.

How to roll back

  • Before it merges: close this pull request.
  • A bad image, not this change: set the repository variable SDLC_IMAGE to the last good release (X.Y.Z). CI uses it on its next run, with no pull request; the organization variable does the same fleet-wide. Locally, SDLC_IMAGE=X.Y.Z git push.
  • This change itself: git revert its squash commit on the default branch. That restores the pinned hooks and workflows exactly as they were.

It merges itself (squash) when its required checks pass. Opened by python-sdlc's scripts/fleet_wave.py; a re-run of the wave reuses the branch chore/sdlc-floating and this pull request.

Converted by python-sdlc's scripts/convert_repo.py. The hooks and the
`sdlc ci` job run .sdlc/bin/sdlc, which takes its launcher from
quay.io/crunchtools/sdlc:latest, so nothing in this repo pins a python-sdlc
release and no version-bump pull request follows this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fatherlinux
fatherlinux enabled auto-merge (squash) November 17, 2026 22:29

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found 1 issues (1 medium)

Full review.

4 finding(s) dropped: their evidence is not in the diff.

Comment thread .sdlc/bin/sdlc

# --pull=newer: :latest moves, and a stale local copy is how a two-week-old
# reviewer once judged trentina. Offline, podman keeps the copy it has.
if ! podman --events-backend=none run --rm --log-driver=none --network=none \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Performance Check): Every hook invocation starts a container solely to print the launcher, then runs that launcher, which starts the checks. This adds a redundant container startup—and a --pull=newer registry check—to each commit and push hook.

Suggestion: Cache the printed launcher by image reference or digest and refresh it only when the image changes, or otherwise avoid starting a separate container just to retrieve the launcher.

Evidence:

podman --events-backend=none run --rm --log-driver=none --network=none \
       --cap-drop=all --security-opt=no-new-privileges --pull=newer \
       -- "$image" launcher "$image" > "$dir/sdlc"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: .sdlc/bin/sdlc is the shared floating bootstrap, byte-identical in every repo and pinned by sha256 in constitution v1.46.0. Pulling sdlc:latest on each run is the design (python-sdlc 0.9.0).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jf39CzcsfQWLaZQnLK

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Reviewed 1 commit since 3f55f14 (incremental).

@fatherlinux
fatherlinux merged commit 8a1bbf4 into main Nov 17, 2026
15 checks passed
@fatherlinux
fatherlinux deleted the chore/sdlc-floating branch November 17, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant