Repository navigation
feat: sign the image in promote (rhel10-bootc-server#47) - #105
Conversation
Turn on constitution container-release.yml's sign: true and pass the cosign-signing environment's COSIGN_PRIVATE_KEY and COSIGN_PASSWORD, the same change as crunchtools/mcp-nagios#101. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jeqWyD1kaUDpcBw3TN
| secrets: | ||
| QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} | ||
| QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} | ||
| COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }} |
There was a problem hiding this comment.
HIGH (Bug Hunter): These expressions are evaluated in the caller workflow, but the changelog says the signing secrets are stored in the cosign-signing environment. Environment-scoped secrets are not available to the caller unless its job references that environment. A reusable-workflow call cannot bind an environment on the caller job, so these values will be empty and signing will fail.
Suggestion: Make the signing secrets available to the caller job, or have the reusable workflow bind the cosign-signing environment and read the secrets there rather than passing them through caller-side expressions.
Evidence:
secrets:
COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}
COSIGN_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}
There was a problem hiding this comment.
Not a bug: the called workflow's promote job sets environment: cosign-signing when sign is true (constitution v1.51.0 container-release.yml), so the secrets resolve there. The identical change in crunchtools/mcp-nagios#101 signed quay.io/crunchtools/mcp-nagios:main and cosign verify passes.
Turns on
sign: truein the call to constitution'scontainer-release.ymland passes thecosign-signingenvironment'sCOSIGN_PRIVATE_KEYandCOSIGN_PASSWORD, the same change as crunchtools/mcp-nagios#101. Promote signs the gated digest before any tag moves; a pull request's candidate is never signed, so this PR's CI does not exercise the key.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jeqWyD1kaUDpcBw3TN