Skip to content

feat: sign the image in promote (rhel10-bootc-server#47) - #105

Merged
fatherlinux merged 1 commit into
mainfrom
feat/sign-images
Nov 19, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
feat/sign-images

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Turns on sign: true in the call to constitution's container-release.yml and passes the cosign-signing environment's COSIGN_PRIVATE_KEY and COSIGN_PASSWORD, the same change as crunchtools/mcp-nagios#101. Promote signs the gated digest before any tag moves; a pull request's candidate is never signed, so this PR's CI does not exercise the key.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jeqWyD1kaUDpcBw3TN

Turn on constitution container-release.yml's sign: true and pass the
cosign-signing environment's COSIGN_PRIVATE_KEY and COSIGN_PASSWORD, the
same change as crunchtools/mcp-nagios#101.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jeqWyD1kaUDpcBw3TN

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found 1 issues (1 high)

Full review.

secrets:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIGH (Bug Hunter): These expressions are evaluated in the caller workflow, but the changelog says the signing secrets are stored in the cosign-signing environment. Environment-scoped secrets are not available to the caller unless its job references that environment. A reusable-workflow call cannot bind an environment on the caller job, so these values will be empty and signing will fail.

Suggestion: Make the signing secrets available to the caller job, or have the reusable workflow bind the cosign-signing environment and read the secrets there rather than passing them through caller-side expressions.

Evidence:

secrets:
  COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}
  COSIGN_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: the called workflow's promote job sets environment: cosign-signing when sign is true (constitution v1.51.0 container-release.yml), so the secrets resolve there. The identical change in crunchtools/mcp-nagios#101 signed quay.io/crunchtools/mcp-nagios:main and cosign verify passes.

@fatherlinux
fatherlinux merged commit b57a425 into main Nov 19, 2026
24 of 25 checks passed
@fatherlinux
fatherlinux deleted the feat/sign-images branch November 19, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant