Repository navigation
fix: run codeql inside sdlc ci - #113
Merged
Merged
Conversation
`[tool.sdlc.ci] skip = ["codeql"]` kept CodeQL out of the one tier anything enforces. Constitution XII says CI runs push's checks except Gourmand and Gatehouse; CodeQL is one of push's verdicts. With the skip in place the only thing that could block on a CodeQL finding was the pre-push hook -- a developer's machine, one `--no-verify` away -- while the required `sdlc ci` reported green. The comment justifying the skip said the CodeQL Action covered it. The Action does run on pull requests here, but its check is advisory: no ruleset requires it, so a finding annotated the PR and merged anyway. With CodeQL in, one finding appears: `py/overly-permissive-file` at test/test_api.py:207, the `os.chmod(target, 0o644)` in a `finally` that puts back the mode the test took away to prove CrunchLog raises DataFileError on an unreadable file. The file is in tmp_path and the chmod is the cleanup, not a permission the product ever sets. Recorded in .sdlc/codeql-baseline.json, so a new finding still fails. One of 24 repos; python-sdlc#19 then refuses this config so it cannot come back. RT#1552. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6
fatherlinux
enabled auto-merge (squash)
November 5, 2026 01:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
[tool.sdlc.ci] skip = ["codeql"], so CodeQL runs in the requiredsdlc cicheck.Why
Constitution XII: "CI runs push's checks except Gourmand and Gatehouse." CodeQL is one of push's verdicts, and the two exclusions are the image's decision, not a repo's. With the skip, the only place a CodeQL finding could block was the pre-push hook — a developer's machine, one
--no-verifyaway — while the requiredsdlc cireported green.The skip's comment claimed the CodeQL Action covered it. The CodeQL Action does run on pull requests here, but its check is advisory: no ruleset requires it, so a finding annotated the PR and merged anyway.
I wrote that skip during the RT#1552 conversion, into 24 of the 33 repos. This is one of the 24. python-sdlc#19 then makes
resolve()refuse the config, so it cannot come back quietly.What CodeQL found
With CodeQL in, one finding appears:
py/overly-permissive-fileattest/test_api.py:207— theos.chmod(target, 0o644)in afinallythat restores the mode the test took away to proveCrunchLograisesDataFileErroron an unreadable file. The file is undertmp_pathand the chmod is cleanup, not a permission the product sets. Recorded in.sdlc/codeql-baseline.json, so a new finding still fails.Verification
sdlc cirun locally with CodeQL in it: exit 0.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6