Repository navigation
feat(ci): sign the promoted image with the fleet cosign key - #42
Conversation
Hosts are moving to trust only signed quay.io/crunchtools images (crunchtools/rhel10-bootc-server#47). container-release.yml's promote signs the gated digest before any tag moves, using COSIGN_PRIVATE_KEY and COSIGN_PASSWORD from this repo's cosign-signing environment. Same change as crunchtools/mcp-nagios#101. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jgQzPHsAyyjYY7kKir
| secrets: | ||
| QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} | ||
| QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} | ||
| COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }} |
There was a problem hiding this comment.
HIGH (Bug Hunter): These expressions are evaluated in the caller workflow, but the changelog says the signing keys are stored in the cosign-signing environment. Environment secrets are only available to jobs that declare that environment; a reusable-workflow caller cannot access them through its secrets context. If the keys exist only in that environment, both values passed here are empty and signing will fail.
Suggestion: Make the secrets available in the caller context, or have the called workflow job declare and use the cosign-signing environment so it can read the environment secrets directly.
Evidence:
COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}
COSIGN_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}
There was a problem hiding this comment.
Not a bug: constitution v1.51.0 container-release.yml's promote job declares environment: ${{ inputs.sign && 'cosign-signing' || '' }} (line 510), so the secrets passed by name resolve from the cosign-signing environment inside the called job, which is what the workflow documents. crunchtools/mcp-nagios#101 uses this identical wiring and its :main passes cosign verify.
Hosts are moving to trust only signed
quay.io/crunchtoolsimages (crunchtools/rhel10-bootc-server#47). This setssign: trueon constitution v1.51.0'scontainer-release.ymland passesCOSIGN_PRIVATE_KEY/COSIGN_PASSWORDby name; the promote job runs in this repo'scosign-signingenvironment and signs the gated digest before any tag moves.Same change as crunchtools/mcp-nagios#101, which is merged and passes
cosign verify. Part of a548.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jgQzPHsAyyjYY7kKir