Skip to content

feat(ci): sign the promoted image with the fleet cosign key - #42

Merged
fatherlinux merged 1 commit into
masterfrom
feat/sign-images
Nov 19, 2026
Merged

fatherlinux merged 1 commit into
masterfrom
feat/sign-images

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Hosts are moving to trust only signed quay.io/crunchtools images (crunchtools/rhel10-bootc-server#47). This sets sign: true on constitution v1.51.0's container-release.yml and passes COSIGN_PRIVATE_KEY / COSIGN_PASSWORD by name; the promote job runs in this repo's cosign-signing environment and signs the gated digest before any tag moves.

Same change as crunchtools/mcp-nagios#101, which is merged and passes cosign verify. Part of a548.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jgQzPHsAyyjYY7kKir

Hosts are moving to trust only signed quay.io/crunchtools images
(crunchtools/rhel10-bootc-server#47). container-release.yml's promote
signs the gated digest before any tag moves, using COSIGN_PRIVATE_KEY and
COSIGN_PASSWORD from this repo's cosign-signing environment. Same change
as crunchtools/mcp-nagios#101.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jgQzPHsAyyjYY7kKir

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found 1 issues (1 high)

Full review.

1 finding(s) dropped: their evidence is not in the diff.

secrets:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIGH (Bug Hunter): These expressions are evaluated in the caller workflow, but the changelog says the signing keys are stored in the cosign-signing environment. Environment secrets are only available to jobs that declare that environment; a reusable-workflow caller cannot access them through its secrets context. If the keys exist only in that environment, both values passed here are empty and signing will fail.

Suggestion: Make the secrets available in the caller context, or have the called workflow job declare and use the cosign-signing environment so it can read the environment secrets directly.

Evidence:

COSIGN_PRIVATE_KEY: ${{ secrets.COSIGN_PRIVATE_KEY }}
COSIGN_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug: constitution v1.51.0 container-release.yml's promote job declares environment: ${{ inputs.sign && 'cosign-signing' || '' }} (line 510), so the secrets passed by name resolve from the cosign-signing environment inside the called job, which is what the workflow documents. crunchtools/mcp-nagios#101 uses this identical wiring and its :main passes cosign verify.

@fatherlinux
fatherlinux merged commit 6b9b355 into master Nov 19, 2026
18 of 19 checks passed
@fatherlinux
fatherlinux deleted the feat/sign-images branch November 19, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant