Skip to content

sdlc ci does not say which push verdicts a repo's [tool.sdlc.push] skip removed #50

Closed

Description

@fatherlinux

[tool.sdlc.ci] skip may not name a push verdict, so the only way to drop one from ci is [tool.sdlc.push] skip. That works as designed, but the ci run never mentions it. A skipped verdict (codeql, pip-audit, and lint from #49) just doesn't appear in the output. sdlc tiers lists what runs, not what was removed, and it prints SDLC_SKIP but not config skips.

So someone reading a green sdlc ci can't tell a repo that ran lint from one that opted out, short of reading its pyproject.toml.

Proposed: in resolve()/the plan for ci, collect the DEFAULTS["push"] verdicts missing because of the push block's skip and print one line per run, e.g. sdlc ci: not run, skipped in [tool.sdlc.push]: lint, codeql. sdlc tiers should print the same. Add a test_plan.py check for it.

Found while reviewing #49 (a143). This was already true before #49 for every push verdict, so it is not a blocker for that PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb

Activity

  1. github-actions commented on Nov 17, 2026

    @github-actions

    Ashigaru triage: feature (80%), needs a maintainer's decision

    The issue's description is accurate. In sdlc, resolve(cfg, "ci") (around lines 253-290) builds its base from resolve(cfg, "push") minus CI_EXCLUDES. Verdicts dropped by (tool.sdlc.push) skip therefore vanish silently. t_tiers() (around line 477) prints only the checks that run, plus SDLC_SKIP, and never prints config skips. This is a request for new user-facing output rather than wrong behaviour. A fix would compute set(DEFAULTS("push")) - set(CI_EXCLUDES) - set(resolve(cfg, "push")) (skipped by the push block's config skip, not SDLC_SKIP or CI_EXCLUDES), print one line such as sdlc ci: not run, skipped in (tool.sdlc.push): lint, codeql in the ci run path and in t_tiers, and add a check in tests/test_plan.py. Open points: the ci run output code is not in resolve(), and plan output is tab-separated and machine-parsed, so the new line must not corrupt it, and the contract tests may pin the output. Question for the maintainer: should the line go to stderr or stdout for sdlc ci (stdout is parsed by tests and hosts), and should t_tiers print it per tier or once?

    Answer the question above in a comment, then add ready-to-code. Ashigaru reads the answer first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesttriagedAshigaru: triaged, waiting for a human decision

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions