Repository navigation
fix: mint the CI token by client-id, not the deprecated app-id - #11
Merged
Merged
Conversation
actions/create-github-app-token@v3 logs `Input 'app-id' has been deprecated with message: Use 'client-id' instead.` Nothing is broken yet, but the input goes away in the action's next major version, and then every workflow in the org that mints a token fails at the token step -- which a Dependabot bump to @v4 would deliver all at once. The client ID is public (`gh api apps/crunchtools-ci --jq .client_id`), so it is an org variable rather than a secret, and the `vars.X || secrets.X` fallback the App ID needed is gone with it. The private key is unchanged. RT#1554 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/create-github-app-token@v3logs:Nothing is broken today. The input goes away in the action's next major
version, and because the action is pinned at
@v3the removal reaches us as aDependabot bump to
@v4— which would turn a routine dependency PR into everytoken-minting workflow in the org failing at once.
The client ID is public (
gh api apps/crunchtools-ci --jq .client_id), so it isan org variable, not a secret, and the
vars.X || secrets.Xfallback the AppID needed goes with it.
CRUNCHTOOLS_CI_APP_KEYis unchanged.RT#1554. Part of the fleet program that also carries RT#1552; two corrections
to the ticket came out of the sweep:
app-id:lines areASHIGARU_APP_ID, so there are two org variables, not one:CRUNCHTOOLS_CI_CLIENT_IDandASHIGARU_CLIENT_ID.ubi10-httpd-perl-mariadbwas missed by the ticket's scope. Itsbuild.ymldispatches tortand carries the deprecated input. Real scope is21 lines across 19 files in 13 repos, not 18 files in 12.
🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6