Skip to content

fix: mint the CI token by client-id, not the deprecated app-id - #11

Merged
fatherlinux merged 1 commit into
mainfrom
fix/1554-ci-client-id
Nov 4, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
fix/1554-ci-client-id

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

actions/create-github-app-token@v3 logs:

Input 'app-id' has been deprecated with message: Use 'client-id' instead.

Nothing is broken today. The input goes away in the action's next major
version, and because the action is pinned at @v3 the removal reaches us as a
Dependabot bump to @v4 — which would turn a routine dependency PR into every
token-minting workflow in the org failing at once.

The client ID is public (gh api apps/crunchtools-ci --jq .client_id), so it is
an org variable, not a secret, and the vars.X || secrets.X fallback the App
ID needed goes with it. CRUNCHTOOLS_CI_APP_KEY is unchanged.

RT#1554. Part of the fleet program that also carries RT#1552; two corrections
to the ticket came out of the sweep:

  • ashigaru mints a different App. Its 6 app-id: lines are
    ASHIGARU_APP_ID, so there are two org variables, not one:
    CRUNCHTOOLS_CI_CLIENT_ID and ASHIGARU_CLIENT_ID.
  • ubi10-httpd-perl-mariadb was missed by the ticket's scope. Its
    build.yml dispatches to rt and carries the deprecated input. Real scope is
    21 lines across 19 files in 13 repos, not 18 files in 12.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6

actions/create-github-app-token@v3 logs `Input 'app-id' has been deprecated
with message: Use 'client-id' instead.` Nothing is broken yet, but the input
goes away in the action's next major version, and then every workflow in the
org that mints a token fails at the token step -- which a Dependabot bump to
@v4 would deliver all at once.

The client ID is public (`gh api apps/crunchtools-ci --jq .client_id`), so it
is an org variable rather than a secret, and the `vars.X || secrets.X` fallback
the App ID needed is gone with it. The private key is unchanged.

RT#1554

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

@fatherlinux
fatherlinux merged commit 5d8469f into main Nov 4, 2026
10 checks passed
@fatherlinux
fatherlinux deleted the fix/1554-ci-client-id branch November 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant