Skip to content

fix: v0.2.1 a passing review no longer fails the push - #3

Merged
fatherlinux merged 1 commit into
mainfrom
fix/stale-exit-status
Nov 4, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
fix/stale-exit-status

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

run_in_image never reset its exit-status variable, so git diff --quiet (1 whenever there is a diff) leaked into a successful Gatehouse run: every push with a branch to review printed "No issues found" and then failed. Present since v0.1.0, found on trentina's first push through v0.2.0.

  • tests/test_host_contract.sh has a regression case; it fails without the fix and passes with it

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jfy8tZHovMEJUNjjD2

run_in_image never reset its exit-status variable, and shell function
variables are global, so t_gatehouse's `git diff --quiet` -- 1 whenever there
IS a diff -- left a 1 that the container's success never overwrote. Every push
with a branch to review printed "No issues found" and then failed. Present
since v0.1.0; trentina's first push through v0.2.0 is what showed it.

tests/test_host_contract.sh now runs gatehouse with a git shim that has a diff
and a podman that passes, and fails without this fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jfy8tZHovMEJUNjjD2

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

@fatherlinux
fatherlinux merged commit 8293cf4 into main Nov 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant