Repository navigation
fix: v0.2.1 a passing review no longer fails the push - #3
Merged
Merged
Conversation
run_in_image never reset its exit-status variable, and shell function variables are global, so t_gatehouse's `git diff --quiet` -- 1 whenever there IS a diff -- left a 1 that the container's success never overwrote. Every push with a branch to review printed "No issues found" and then failed. Present since v0.1.0; trentina's first push through v0.2.0 is what showed it. tests/test_host_contract.sh now runs gatehouse with a git shim that has a diff and a podman that passes, and fails without this fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jfy8tZHovMEJUNjjD2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_in_image never reset its exit-status variable, so
git diff --quiet(1 whenever there is a diff) leaked into a successful Gatehouse run: every push with a branch to review printed "No issues found" and then failed. Present since v0.1.0, found on trentina's first push through v0.2.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jfy8tZHovMEJUNjjD2