Skip to content

fix(ci): release only on "release not found" and an exact CHANGELOG heading - #57

Merged
fatherlinux merged 2 commits into
mainfrom
fix/release-version-check
Nov 17, 2026
Merged

fatherlinux merged 2 commits into
mainfrom
fix/release-version-check

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Two flaws in release.yml's "is there an untagged version?" step, the same two Gatehouse found in crunchtools/rhel10-bootc-workstation#34:

  • Every gh release view failure counted as unreleased. An auth, network or rate-limit error looked like a version waiting to ship. Now only release not found means unreleased, and any other failure prints gh's output and fails the job.
  • The CHANGELOG heading was matched as a regex. The dots in 0.7.3 matched any character. Now the line must start with ## [X.Y.Z] literally and end there or continue with a space.

The decision moves out of inline YAML into scripts/release-version.sh, so it can be tested. tests/test_release_version.py runs it against a fake gh in 8 cases (released, unreleased, no heading, 0x7x3, 0.7.30, a gh 401, no version). container.yml shellchecks the script and runs the test on the host, next to the host-contract check. The pre-commit shellcheck hook covers the script too.

No version bump: there's a CHANGELOG [Unreleased] entry, and the next release PR rolls it up.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb

Josui and others added 2 commits November 17, 2026 14:23
…eading

release.yml treated every `gh release view` failure as unreleased, so an
auth or network error looked like a version to ship, and matched the
CHANGELOG heading as a regex, so a version's dots matched any character.
The decision moves to scripts/release-version.sh, shellchecked and covered
by tests/test_release_version.py against a fake gh. Same fix as
crunchtools/rhel10-bootc-workstation 289eee6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

@fatherlinux
fatherlinux merged commit fc30df6 into main Nov 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant