Repository navigation
fix(ci): release only on "release not found" and an exact CHANGELOG heading - #57
Merged
Merged
Conversation
…eading release.yml treated every `gh release view` failure as unreleased, so an auth or network error looked like a version to ship, and matched the CHANGELOG heading as a regex, so a version's dots matched any character. The decision moves to scripts/release-version.sh, shellchecked and covered by tests/test_release_version.py against a fake gh. Same fix as crunchtools/rhel10-bootc-workstation 289eee6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flaws in
release.yml's "is there an untagged version?" step, the same two Gatehouse found in crunchtools/rhel10-bootc-workstation#34:gh release viewfailure counted as unreleased. An auth, network or rate-limit error looked like a version waiting to ship. Now onlyrelease not foundmeans unreleased, and any other failure prints gh's output and fails the job.0.7.3matched any character. Now the line must start with## [X.Y.Z]literally and end there or continue with a space.The decision moves out of inline YAML into
scripts/release-version.sh, so it can be tested.tests/test_release_version.pyruns it against a fakeghin 8 cases (released, unreleased, no heading,0x7x3,0.7.30, a gh 401, no version).container.ymlshellchecks the script and runs the test on the host, next to the host-contract check. The pre-commit shellcheck hook covers the script too.No version bump: there's a CHANGELOG
[Unreleased]entry, and the next release PR rolls it up.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jckWHhAgXg2WBwkWbb