Skip to content

fix: convert_repo floats a shared-file sdlc ci step to the exact launcher line (a227) - #65

Merged
fatherlinux merged 1 commit into
mainfrom
fix/converter-exact-ci-step
Nov 17, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
fix/converter-exact-ci-step

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Two converter gaps that the fleet wave hit on gatehouse:

  • A floated sdlc ci step that shares its workflow kept set -eu above .sdlc/bin/sdlc ci in a run: | block. Constitution v1.46.0's check_floating_ci wants the run to be exactly the launcher, so the required check failed. The whole step is now run: .sdlc/bin/sdlc ci. A block an earlier run left with set -eu is rewritten in place, so re-running the wave fixes those repos. A pinned step with anything else in its block is refused, and the final verify compares the run exactly, as the validator does.
  • The pinned-form regex now accepts a quoted launcher path ("$RUNNER_TEMP/sdlc/bin/sdlc" ci). The quotes must match.

Tests cover the quoted path, the leftover block, idempotence for both, a trailing line (refused) and mismatched quotes (refused). The existing shared-file assertions now check the exact run line.

Local hooks didn't run: the developer gateway refuses astral-sh/ruff-pre-commit (repo_not_listed). I ran ruff check/format and tests/test_convert_repo.py in quay.io/crunchtools/sdlc:latest by hand, and they all pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh

…cher line (a227)

A floated step kept `set -eu` above `.sdlc/bin/sdlc ci` in a `run: |`
block, which constitution v1.46.0's check_floating_ci fails: the run must
be exactly the launcher. The whole step is now rewritten to
`run: .sdlc/bin/sdlc ci`, a block an earlier run left with `set -eu` is
fixed in place, a pinned step with more in its block is refused, and the
final verify reads the run as the validator does. The pinned form also
accepts a quoted launcher path, which made the wave refuse gatehouse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

3 finding(s) dropped: their evidence is not in the diff.

1 of 8 agents served by google/gemini-3.5-flash-lite (primary unavailable).

@fatherlinux
fatherlinux merged commit f607ceb into main Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant