Repository navigation
fix: convert_repo floats a shared-file sdlc ci step to the exact launcher line (a227) - #65
Merged
Merged
Conversation
…cher line (a227) A floated step kept `set -eu` above `.sdlc/bin/sdlc ci` in a `run: |` block, which constitution v1.46.0's check_floating_ci fails: the run must be exactly the launcher. The whole step is now rewritten to `run: .sdlc/bin/sdlc ci`, a block an earlier run left with `set -eu` is fixed in place, a pinned step with more in its block is refused, and the final verify reads the run as the validator does. The pinned form also accepts a quoted launcher path, which made the wave refuse gatehouse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two converter gaps that the fleet wave hit on gatehouse:
sdlc cistep that shares its workflow keptset -euabove.sdlc/bin/sdlc ciin arun: |block. Constitution v1.46.0'scheck_floating_ciwants the run to be exactly the launcher, so the required check failed. The whole step is nowrun: .sdlc/bin/sdlc ci. A block an earlier run left withset -euis rewritten in place, so re-running the wave fixes those repos. A pinned step with anything else in its block is refused, and the final verify compares the run exactly, as the validator does."$RUNNER_TEMP/sdlc/bin/sdlc" ci). The quotes must match.Tests cover the quoted path, the leftover block, idempotence for both, a trailing line (refused) and mismatched quotes (refused). The existing shared-file assertions now check the exact run line.
Local hooks didn't run: the developer gateway refuses
astral-sh/ruff-pre-commit(repo_not_listed). I ran ruff check/format andtests/test_convert_repo.pyinquay.io/crunchtools/sdlc:latestby hand, and they all pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7Y1jg3ZJ6BsAEfhrPWFRh