Repository navigation
chore: float the sdlc gates on quay.io/crunchtools/sdlc - #35
Conversation
Converted by python-sdlc's scripts/convert_repo.py. The hooks and the `sdlc ci` job run .sdlc/bin/sdlc, which takes its launcher from quay.io/crunchtools/sdlc:latest, so nothing in this repo pins a python-sdlc release and no version-bump pull request follows this one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
||
| # The value, with the repository named in full or not at all. | ||
| want=${SDLC_IMAGE:-latest} | ||
| case $want in |
There was a problem hiding this comment.
MEDIUM (Test Coverage): The new launcher has substantial untested branching: it accepts and normalizes several image-reference forms, rejects malformed tags and digests, handles Podman or launcher failures, and invokes the printed launcher with a checked image reference. No corresponding tests are included, leaving the gate’s image-selection and failure behavior unverified.
Suggestion: Add tests using a stub podman on PATH to cover accepted and rejected references, digest length and character boundaries, Podman failure or empty launcher output, and forwarding the validated image reference and arguments to the launcher.
Evidence:
case $want in
main|latest) image=$FLEET:$want ;;
@sha256:*)
hex=${want#@sha256:}
case $hex in *[!0-9a-f]*) refuse ;; esac
[ "${#hex}" -eq 64 ] || refuse
image=$FLEET$want ;;
*[!0-9.]*|.*|*.|*..*|*.*.*.*) refuse ;;
*.*.*) image=$FLEET:$want ;;
*) refuse ;;
esac
...
if ! podman ... "$image" launcher "$image" > "$dir/sdlc" || [ ! -s "$dir/sdlc" ]; then
...
fi
SDLC_IMAGE=$image sh "$dir/sdlc" "$@"
There was a problem hiding this comment.
Not a bug: .sdlc/bin/sdlc is the shared floating bootstrap, byte-identical in every repo and pinned by sha256 in constitution v1.46.0. Pulling sdlc:latest on each run is the design (python-sdlc 0.9.0).
|
|
||
| name: CI | ||
|
|
||
| on: |
There was a problem hiding this comment.
HIGH (Constitution): This workflow has no weekly cron trigger, despite the requirement that workflows include one for base image security updates.
Suggestion: Add a weekly schedule trigger to this workflow.
Evidence:
on:
push:
branches: [main, master]
pull_request:
workflow_dispatch:
There was a problem hiding this comment.
Not a bug: ci.yml is the sdlc checks workflow (python-sdlc's examples/ci.yml, copied unchanged) and builds no image, so profile V's weekly rebuild does not apply to it. This image is rebuilt by container.yml, which the ubi10 cascade drives through parent-image-updated from ubi10-core's weekly cron.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7Y1jf39CzcsfQWLaZQnLK
There was a problem hiding this comment.
Gatehouse found no issues.
Reviewed 1 commit since 434446f (incremental).
The last fleet-wide PR wave: this repo's gates move to the floating sdlc, so what they run changes when the image does and no pull request has to bump a pin.
What changed
.sdlc/bin/sdlc(new, executable): python-sdlc'sbin/sdlc-bootstrap. It asksquay.io/crunchtools/sdlcfor its launcher and runs it. It names no release, so nothing ever bumps it..pre-commit-config.yaml: the rev-pinned python-sdlc hooks (or the standalone Gourmand and Gatehouse hooks) become two local hooks running.sdlc/bin/sdlc commitand.sdlc/bin/sdlc push. Other hooks are kept..github/workflows/: thesdlc cijob runs.sdlc/bin/sdlc ciwithSDLC_IMAGE: ${{ vars.SDLC_IMAGE }}. Its name, and so the required check, is unchanged. Workflows the stub does not cover are kept;quay.io/crunchtools/python-sdlcbecomesquay.io/crunchtools/sdlc..specify/is not touched.How to roll back
SDLC_IMAGEto the last good release (X.Y.Z). CI uses it on its next run, with no pull request; the organization variable does the same fleet-wide. Locally,SDLC_IMAGE=X.Y.Z git push.git revertits squash commit on the default branch. That restores the pinned hooks and workflows exactly as they were.It merges itself (squash) when its required checks pass. Opened by python-sdlc's
scripts/fleet_wave.py; a re-run of the wave reuses the branchchore/sdlc-floatingand this pull request.