Skip to content

merge queue: merged #88: align CSI-Addons specifications with the CSI specification format - #90

Closed
mergify[bot] wants to merge 8 commits into
mainfrom
mergify/merge-queue/4ae3ee4ae2
Closed

mergify[bot] wants to merge 8 commits into
mainfrom
mergify/merge-queue/4ae3ee4ae2

Conversation

@mergify

@mergify mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Note

This is a merge queue draft opened by Mergify. Its pull request has merged, and nobody needs to act on it.
Mergify opened it for batch urbane-axoa-pxov2a of the default queue, to test #88 before it merged into main.

🎉 What landed

Mergify merged its pull request into main, then closed this draft:

  • #88 align CSI-Addons specifications with the CSI specification format (Madhu-1), as 8bf9451

This draft's code was built in this order:

  1. main at 80d74f9
  2. #88, the pull request of this batch
Metadata for CI tooling, read by mergify ci
---
all_scopes: false
checking_base_sha: 80d74f987a5485ba8fbd9ff279657211ad7400cf
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 88
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
Required conditions to stay in the queue

Madhu-1 and others added 8 commits November 12, 2026 17:29
Bring the VolumeReplication spec to CSI specification documentation parity:

- replace the placeholder '# spec' title; add Notational Conventions (RFC 2119)
- add an Error Handling section that documents the gRPC status conventions
  (status.message / status.details) and the error codes common to all RPCs, and
  leave only RPC-specific codes (NOT_FOUND, FAILED_PRECONDITION, UNAVAILABLE) in
  each per-RPC table, mirroring the CSI spec's structure
- add a high-level description, capability statement (VolumeReplication
  VOLUME_REPLICATION / GET_REPLICATION_DESTINATION_INFO) and
  idempotency/behavioral semantics to every RPC
- rename the generic '#### Error Scheme' headings to '#### <RPC> Errors'
- add a description for ReplicationSource
- fix typos (avaiable, retrived, 'in not replicated', 'a unknown')
- add the 'Replication Source cannot be enabled' (9 FAILED_PRECONDITION) row to
  EnableVolumeReplication to match the reference implementation
  (enableReplicationKnownErrors in volumereplication_controller.go)
- GetVolumeReplicationInfo documents status as REQUIRED (matching the proto), and
  DisableVolumeReplication states a single rule for a missing source (NOT_FOUND)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
- add Notational Conventions (RFC 2119), Terminology, Objective/Goals/Non-Goals,
  Solution Overview, Architecture and Secrets Requirements sections
- add an Error Handling section with the gRPC status conventions and the error
  codes common to all RPCs; leave only RPC-specific codes in each per-RPC table,
  mirroring the CSI spec
- state the objective's modify/query RPCs as capability-gated, consistent with the
  per-RPC capability requirements
- promote the RPC/Errors headings so heading levels increment by one
- correct the gRPC code for 'Volumes cannot be grouped together' from the wrong
  '7 FAILED_PRECONDITION' to '9 FAILED_PRECONDITION' (code 7 is PERMISSION_DENIED)
- fix 'PRC' typos

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
- add Notational Conventions (RFC 2119) and an Architecture section
- add an Error Handling section with the gRPC status conventions and the error
  codes common to all RPCs; each per-RPC Errors section references it and defines
  no additional codes, mirroring the CSI spec
- add a description, capability statement (NetworkFence NETWORK_FENCE /
  GET_CLIENTS_TO_FENCE) and behavioral/idempotency semantics to every RPC, plus a
  description for ClientDetails
- remove the unused 'DR' terminology entry

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
- add Notational Conventions (RFC 2119) and an Architecture section
- add an Error Handling section with the gRPC status conventions and the error
  codes common to all RPCs; the EncryptionKeyRotate Errors table keeps only the
  RPC-specific NOT_FOUND code, mirroring the CSI spec
- add a high-level EncryptionKeyRotate description, capability statement
  (EncryptionKeyRotation) and behavioral/retry semantics
- add the 'Call not implemented' (UNIMPLEMENTED) common code, matching the
  controller's Unimplemented handling
- normalise the title to 'CSI-Addons' and fix 'encrpytion'/'a unknown' typos

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
- add Notational Conventions (RFC 2119) and an Architecture section
- add an Error Handling section with the gRPC status conventions and the error
  codes common to all RPCs; each per-RPC table keeps only RPC-specific codes
  (NOT_FOUND and the specialized UNIMPLEMENTED for storage that cannot reclaim),
  mirroring the CSI spec
- add a high-level description, capability statement (ReclaimSpace OFFLINE for
  the Controller, ONLINE for the Node) and idempotency/behavioral semantics to
  both RPCs

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
- add Notational Conventions (RFC 2119) and an Error Handling section (gRPC
  status / status.message / status.details conventions)
- add the 'general flow of the success case' example (GetIdentity,
  GetCapabilities, Probe) that the CSI Identity service documents

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
The top-level README listed only four of the operation specs. Add entries for
the Identity service and the Encryption Key Rotation operation so every
specification in the repository is linked from the index.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d0e701de-be34-4482-921c-99fdb5e4fc08

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mergify mergify Bot changed the title merge queue: checking #88 on main (80d74f9) merge queue: merged #88: align CSI-Addons specifications with the CSI specification format Nov 13, 2026
@mergify mergify Bot closed this Nov 13, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/4ae3ee4ae2 branch November 13, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant