Skip to content

fix: remove dead scalar boundary code - #496

Open
nightcityblade wants to merge 1 commit into
csrc-sdsu:mainfrom
nightcityblade:fix/issue-493-dead-code
Open

nightcityblade wants to merge 1 commit into
csrc-sdsu:mainfrom
nightcityblade:fix/issue-493-dead-code

Conversation

@nightcityblade

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Remove two commented-out sparse-row subtraction snippets from addScalarBC!. The issue discussion confirms that restoring those snippets would reintroduce the implicit-term bug, while the active sparse row replacement remains covered by the existing boundary-condition tests.

Related Issues & Documents

QA Instructions, Screenshots, Recordings

  • Julia 1.12.6 on macOS: all Julia test sources passed (228/228 assertions), including 14/14 addScalarBC! assertions.
  • JuliaFormatter.format("julia/MOLE.jl", overwrite=false, verbose=true) passed.
  • git diff --check passed.

No UI changes or screenshots apply.

Keep-open request

  • I am requesting maintainer review for keep-open.

Reason: N/A

Added/updated tests?

We encourage you to test all code included with MOLE, including examples.

  • Yes
  • No, and this is why: the change only removes inert commented-out code; the complete existing Julia test sources were run instead.
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

@valeriabarra

Copy link
Copy Markdown
Collaborator

Hello @nightcityblade, we cannot accept contributions from anonymous users (i.e., users that do not have a full display name in their GitHub account).

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 14 days. It will be marked stale in 14 days if there is no further activity.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead code in MOLE.jl scalarBC.jl

2 participants