Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the boundary-condition row-clearing changes.
No open issues 🎉
What changed in this PR
Fixes C++ scalar boundary-condition handling when rows being cleared contain nonzero entries, addressing the C++ case related to #475.
Changes:
- Replaces iterator-based element deletion with row-level zeroing and sparse-matrix synchronization.
- Updates boundary-condition tests to use random matrices instead of Laplacians, exercising populated boundary rows.
- Adjusts the periodic 1D test to use
mentries without ghost points.
| File | Description |
|---|---|
tests/cpp/test_addscalarbc.cpp |
Uses random matrices across boundary-condition tests and updates periodic test dimensions. |
src/cpp/addscalarbc.cpp |
Clears boundary rows without modifying entries through an active iterator. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
addscalarbc.cpphelper functionzeroRows()throws an error when there are non-zero elements in the rows that it is zeroing. This is fixed and tests are updated to random matrices rather than mimetic Laplacians.Related Issues & Documents
Added/updated tests?
have not been included
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?