Repository navigation
Tidy add_user_to_groups: single user lookup, skip no-op PATCH - #1492
Open
MariusWirtz wants to merge 1 commit into
Open
MariusWirtz wants to merge 1 commit into
MariusWirtz wants to merge 1 commit into
Conversation
Follow-up to #1490. Resolve the user name once instead of twice, and return None without sending a PATCH when the user is already a member of every requested group. Add mock-based unit tests that assert on the request body, which is the only place the dedupe is observable, and fold the duplicate live test into test_add_user_to_groups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1490.
Resolve the user name once instead of twice, and return None without sending a PATCH when the user is already a member of every requested group.
Add mock-based unit tests that assert on the request body, which is the only place the dedupe is observable, and fold the duplicate live test into test_add_user_to_groups.