Skip to content

Include module JS/TS extensions in default glue globs - #154

Merged
davidjgoss merged 1 commit into
mainfrom
glue-module-extensions
Nov 4, 2026
Merged

davidjgoss merged 1 commit into
mainfrom
glue-module-extensions

Conversation

@davidjgoss

Copy link
Copy Markdown
Member

🤔 What's changed?

  • Add features/**/*.{cjs,mjs,cts,mts} to the default glue globs. These extensions were already parsed, but not matched by the defaults.
  • NodeFiles.findUris now returns absolute paths, so matches resolve against the root URI rather than the process's current directory. This was needed to test the defaults against a fixture project.

⚡️ What's your motivation?

Projects with ESM/CJS-specific step definition files (e.g. steps.mts with @cucumber/node) got no step definitions without overriding glue.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@davidjgoss
davidjgoss marked this pull request as ready for review November 4, 2026 12:49
@davidjgoss
davidjgoss merged commit 8058976 into main Nov 4, 2026
12 checks passed
@davidjgoss
davidjgoss deleted the glue-module-extensions branch November 4, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant